bind: annotate all remaining ObjC types for nullability #29
Conversation
From Xcode 10.2 onwards, these annotations are required in all interface declaractions. The behaviour can be disabled, but since we were already annotation most types it made sense to just annotate the rest.
champo
changed the title
|
This PR (HEAD: a0d951d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mobile/+/171957 to see it. Tip: You can toggle comments from me using the |
|
Message from Elias Naur: Patch Set 1: Please run "go test -short golang.org/x/bind/... -update" to update the golden files and to check your changes. Please don’t reply on this GitHub thread. Visit golang.org/cl/171957. |
|
Message from Elias Naur: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/171957. |
champo
changed the title
|
This PR (HEAD: a431572) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mobile/+/171957 to see it. Tip: You can toggle comments from me using the |
|
Message from Juan Civile: Patch Set 3: (3 comments) Updated the commit message and test golden files Please don’t reply on this GitHub thread. Visit golang.org/cl/171957. |
From Xcode 10.2 onwards, these annotations are required in all interface declarations. The behaviour can be disabled, but since we were already annotated most types it made sense to just annotate the rest. Change-Id: Iacd09a2fea4dfb3e22fec97cf4ca22966fc783bf GitHub-Last-Rev: a431572 GitHub-Pull-Request: #29 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/171957 Reviewed-by: Elias Naur <[email protected]>
|
This PR is being closed because golang.org/cl/171957 has been merged. |
From Xcode 10.2 onwards, these annotations are required in all interface declarations. The behaviour can be disabled, but since we were already annotated most types it made sense to just annotate the rest. Change-Id: Iacd09a2fea4dfb3e22fec97cf4ca22966fc783bf GitHub-Last-Rev: a431572 GitHub-Pull-Request: golang#29 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/171957 Reviewed-by: Elias Naur <[email protected]>
From Xcode 10.2 onwards, these annotations are required in all interface declarations. The behaviour can be disabled, but since we were already annotated most types it made sense to just annotate the rest. Change-Id: Iacd09a2fea4dfb3e22fec97cf4ca22966fc783bf GitHub-Last-Rev: a431572 GitHub-Pull-Request: golang#29 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/171957 Reviewed-by: Elias Naur <[email protected]>
From Xcode 10.2 onwards, these annotations are required in all interface
declarations. The behaviour can be disabled, but since we were already
annotated most types it made sense to just annotate the rest.