cmd/gomobile: support Catalyst and Apple Silicon #63

waylybaye · 2021-01-29T14:49:15Z

This PR is derived from #45 .

I changed the build process and it will create 3 frameworks for ios, simulator and catalyst. Every framework has a fat library contains both arm64 and x86_64 (except ios that only needs arm64).

Finally create one xcframework from all 3 fat frameworks and this xcframework contains every platform and architecture.

create one framework for all targets: ios, simulator and catalyst, every framework contains at least one arch library, and combine all framework into one xcframework

google-cla · 2021-01-29T14:49:22Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

waylybaye · 2021-01-29T14:51:23Z

@googlebot I signed it!

google-cla · 2021-01-29T14:51:29Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

aeddi · 2021-02-02T10:47:21Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@dpwiese Can you confirm your consent with the bot? :)

google-cla · 2021-02-02T10:47:27Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

dpwiese · 2021-02-02T13:42:43Z

@googlebot I consent.

gopherbot · 2021-02-02T13:44:41Z

This PR (HEAD: 8c9ecea) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/288752 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-02-02T13:46:49Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/288752.
After addressing review feedback, remember to publish your drafts!

dpwiese

I'm happy to see this moving along, and think considering targets and architectures separately (as opposed to just treating catalyst as a new architecture as I had) is a much more elegant approach! And great to see Apple Silicon support added. 🎉

I've built my Sample.xcframework from this branch it it works on the target/architecture combos I've tested it quickly on: my old x86_64 mac with both simulator and catalyst, and my arm64 iPhone. Seems to work as expected. 👍

As far as tests, TestBindIOS fails now, but that's expected and should be a quick fix of updating the templates. I also have the TestBindWithGoModules tests failing. And finally TestIOSBuild is failing too, but that was already the case as mentioned in #45 (comment). I'm not sure how much effort should be placed towards these tests given they are failing already, but it would be very nice to get this helpful PR merged in. 🙂

cmd/gomobile/env.go

gopherbot · 2021-02-03T03:16:51Z

Message from Hyang-Ah Hana Kim:

Patch Set 3: Run-TryBot+1 Trust+1

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/288752.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-02-03T03:16:51Z

Message from Go Bot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=79d4c5ae

Please don’t reply on this GitHub thread. Visit golang.org/cl/288752.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-02-03T03:18:47Z

This PR (HEAD: 68a32d9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/288752 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

michaellady · 2021-02-11T20:50:34Z

Would this PR make .xcframeworks built by gomobile compatible with Swift Package Manager (SPM)? If so, my team is very excited for this to move forward!

ydnar · 2021-03-01T18:25:58Z

I’m trying to use this fork with a replace directive in my project’s go.mod file, and it fails with an error:

go: cloud.google.com/[email protected]: missing go.sum entry; to add it:
	go mod download cloud.google.com/go

The full command output:

❯ gomobile bind -target ios ./mobile/ping
[debug] goenv:
[GOOS=darwin GOARCH=arm64 CC=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang CXX=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ CGO_CFLAGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.4.sdk -mios-simulator-version-min=7.0 -fembed-bitcode -arch arm64 CGO_CXXFLAGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.4.sdk -mios-simulator-version-min=7.0 -fembed-bitcode -arch arm64 CGO_LDFLAGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.4.sdk -mios-simulator-version-min=7.0 -fembed-bitcode -arch arm64 CGO_ENABLED=1 ARCH=arm64 GOPATH=/var/folders/6g/1gng3zts0t39s_qbtt7p0wsc0000gn/T/gomobile-work-204926828:/Users/ydnar/go]
gomobile: darwin-arm64: go build -tags ios -buildmode=c-archive -o /var/folders/6g/1gng3zts0t39s_qbtt7p0wsc0000gn/T/gomobile-work-204926828/ping-arm64.a ./gobind failed: exit status 1
go: cloud.google.com/[email protected]: missing go.sum entry; to add it:
	go mod download cloud.google.com/go

Go 1.16 on macOS 11.3 beta, using Xcode 12.4 on an Intel MB Pro.

Edit: I forked this fork and rebased on golang/mobile@master and it worked! ydnar#1

Edit 2: it was trivial to add macOS support to gomobile in this fork, which enables the framework to be packaged and distributed via Swift Package Manager:

https://developer.apple.com/documentation/swift_packages/distributing_binary_frameworks_as_swift_packages

nadimkobeissi · 2021-05-18T17:13:37Z

This is a pretty exciting and important PR, any idea when it will get merged?

Currently, if I try to install it manually, I get this strange error when I run gomobile bind:

[debug] goenv:
[GOOS=darwin GOARCH=arm64 CC=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang CXX=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ CGO_CFLAGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk -mios-simulator-version-min=7.0 -fembed-bitcode -arch arm64 CGO_CXXFLAGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk -mios-simulator-version-min=7.0 -fembed-bitcode -arch arm64 CGO_LDFLAGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk -mios-simulator-version-min=7.0 -fembed-bitcode -arch arm64 CGO_ENABLED=1 ARCH=arm64 GOPATH=/var/folders/sk/85yp792d7xb6nlmnzn23_jf40000gn/T/gomobile-work-735475716:/Users/nadim/go]
gomobile: darwin-arm64: go build -tags ios -gcflags -e -ldflags -s -w -trimpath -buildmode=c-archive -o /var/folders/sk/85yp792d7xb6nlmnzn23_jf40000gn/T/gomobile-work-735475716/MyGoLibrary-arm64.a ./gobind failed: exit status 1
go: github.com/BurntSushi/[email protected]: missing go.sum entry; to add it:
	go mod download github.com/BurntSushi/xgb

Error aside, it would be really cool to see this merged and pushed into stable.

ydnar · 2021-05-18T18:23:12Z

This is a pretty exciting and important PR, any idea when it will get merged?

Currently, if I try to install it manually, I get this strange error when I run gomobile bind:


[debug] goenv:

[GOOS=darwin GOARCH=arm64 CC=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang CXX=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ CGO_CFLAGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk -mios-simulator-version-min=7.0 -fembed-bitcode -arch arm64 CGO_CXXFLAGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk -mios-simulator-version-min=7.0 -fembed-bitcode -arch arm64 CGO_LDFLAGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk -mios-simulator-version-min=7.0 -fembed-bitcode -arch arm64 CGO_ENABLED=1 ARCH=arm64 GOPATH=/var/folders/sk/85yp792d7xb6nlmnzn23_jf40000gn/T/gomobile-work-735475716:/Users/nadim/go]

gomobile: darwin-arm64: go build -tags ios -gcflags -e -ldflags -s -w -trimpath -buildmode=c-archive -o /var/folders/sk/85yp792d7xb6nlmnzn23_jf40000gn/T/gomobile-work-735475716/MyGoLibrary-arm64.a ./gobind failed: exit status 1

go: github.com/BurntSushi/[email protected]: missing go.sum entry; to add it:

	go mod download github.com/BurntSushi/xgb

Error aside, it would be really cool to see this merged and pushed into stable.

See #65 for a build that fixes that issue

gadireddi226 · 2021-06-25T16:59:11Z

When this PR will be merged ?

Add support for macOS (non-Catalyst) and Catalyst targets. The compiled library is packaged into a "fat" XCFramework file (as opposed to a Framework), which includes binaries for iOS, macOS, MacCatalyst (iOS on macOS), and iOS Simulator targets, for amd64 and arm64 architectures. The generated XCFramework file is suitable for distribution as a binary Swift Package Manager package: https://developer.apple.com/documentation/swift_packages/distributing_binary_frameworks_as_swift_packages This change is based on earlier work: #45 #63 Fixes golang/go#36856 Change-Id: Iabe535183c7215c68838d6c8f31618d8bceefdcf GitHub-Last-Rev: 623f8f3 GitHub-Pull-Request: #65 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/310949 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Hajime Hoshi <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]> Trust: Hajime Hoshi <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: Go Bot <[email protected]>

deepumukundan · 2021-07-10T19:02:49Z

Guess we can close this PR now that the fork with these and additional changes has been merged in! Finally closure!

waylybaye · 2021-07-11T01:23:20Z

closed since #65 has been merged

nadimkobeissi · 2021-07-13T09:18:44Z

Thank you so much!

dpwiese and others added 4 commits January 18, 2021 16:11

nominally working example for catalyst

d06c25e

remove mistaken hardcoded framework filenames

ffb4b4a

update test and minor go fmt fix

6cad7ff

Support Apple Silicon and Catalyst

8c9ecea

create one framework for all targets: ios, simulator and catalyst, every framework contains at least one arch library, and combine all framework into one xcframework

google-cla bot added the cla: no label Jan 29, 2021

google-cla bot added cla: yes and removed cla: no labels Feb 2, 2021

hyangah changed the title ~~Support Catalyst and Apple Silicon~~ cmd/gomobile: support Catalyst and Apple Silicon Feb 2, 2021

dpwiese reviewed Feb 3, 2021

View reviewed changes

cmd/gomobile/env.go Outdated Show resolved Hide resolved

remove catalyst in allArchs

68a32d9

aeddi mentioned this pull request Feb 3, 2021

WIP: feat: build macOS Catalyst version of Berty berty/berty#2131

Closed

6 tasks

imWildCat mentioned this pull request Mar 22, 2021

cmd/gomobile: xcframework and catalyst support #64

Closed

ydnar mentioned this pull request Apr 13, 2021

cmd/gomobile: support macOS and Catalyst #65

Closed

waylybaye closed this Jul 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/gomobile: support Catalyst and Apple Silicon #63

cmd/gomobile: support Catalyst and Apple Silicon #63

waylybaye commented Jan 29, 2021 •

edited by hyangah

Loading

google-cla bot commented Jan 29, 2021

waylybaye commented Jan 29, 2021

google-cla bot commented Jan 29, 2021

aeddi commented Feb 2, 2021

google-cla bot commented Feb 2, 2021

dpwiese commented Feb 2, 2021

gopherbot commented Feb 2, 2021

gopherbot commented Feb 2, 2021

dpwiese left a comment

gopherbot commented Feb 3, 2021

gopherbot commented Feb 3, 2021

gopherbot commented Feb 3, 2021

michaellady commented Feb 11, 2021 •

edited

Loading

ydnar commented Mar 1, 2021 •

edited

Loading

nadimkobeissi commented May 18, 2021

ydnar commented May 18, 2021

gadireddi226 commented Jun 25, 2021

deepumukundan commented Jul 10, 2021

waylybaye commented Jul 11, 2021

nadimkobeissi commented Jul 13, 2021

cmd/gomobile: support Catalyst and Apple Silicon #63

cmd/gomobile: support Catalyst and Apple Silicon #63

Conversation

waylybaye commented Jan 29, 2021 • edited by hyangah Loading

google-cla bot commented Jan 29, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

waylybaye commented Jan 29, 2021

google-cla bot commented Jan 29, 2021

aeddi commented Feb 2, 2021

google-cla bot commented Feb 2, 2021

dpwiese commented Feb 2, 2021

gopherbot commented Feb 2, 2021

gopherbot commented Feb 2, 2021

dpwiese left a comment

Choose a reason for hiding this comment

gopherbot commented Feb 3, 2021

gopherbot commented Feb 3, 2021

gopherbot commented Feb 3, 2021

michaellady commented Feb 11, 2021 • edited Loading

ydnar commented Mar 1, 2021 • edited Loading

nadimkobeissi commented May 18, 2021

ydnar commented May 18, 2021

gadireddi226 commented Jun 25, 2021

deepumukundan commented Jul 10, 2021

waylybaye commented Jul 11, 2021

nadimkobeissi commented Jul 13, 2021

waylybaye commented Jan 29, 2021 •

edited by hyangah

Loading

michaellady commented Feb 11, 2021 •

edited

Loading

ydnar commented Mar 1, 2021 •

edited

Loading