Skip to content

example: add Swift Package Manager example #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ydnar
Copy link
Contributor

@ydnar ydnar commented Sep 15, 2021

Add an example Swift package built with gomobile for multiple Apple
platforms (ios, iosimulator, macos, and maccatalyst).

It builds an XCFramework file which is linked as a binary dependency by
Swift Package Manager. The resulting Swift package can be imported into
an iOS, macOS, or Catalyst app and called from Swift.

It has tests written in Swift. To run the tests, run swift test from
the example/swift-package directory.

Depends on golang.org/cl/334689 (#70).

@google-cla google-cla bot added the cla: yes label Sep 15, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: cd53bf5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/350150 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/350150.
After addressing review feedback, remember to publish your drafts!

@ydnar ydnar changed the title mobile: add Swift Package Manager example example: add Swift Package Manager example Sep 16, 2021
@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/350150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/350150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/350150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/350150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: fbf25be) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/350150 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/350150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/350150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/350150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/350150.
After addressing review feedback, remember to publish your drafts!

ydnar added a commit to alta/go-mobile-swift-package-example that referenced this pull request Sep 27, 2021
This breaks out the Swift Package Manager example from
golang/mobile#71 into a separate repo.

See https://golang.org/cl/350150 for additional info.

Depends on https://golang.org/cl/334689 (golang/mobile#70).
@ydnar
Copy link
Contributor Author

ydnar commented Sep 27, 2021

Per CL feedback, I extracted this into a separate repo that folks can link to from the wiki:

https://github.com/alta/go-mobile-swift-package-example

Closing.

@ydnar ydnar closed this Sep 27, 2021
@daimwafa
Copy link

daimwafa commented Sep 27, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants