Skip to content

route: fix spelling of 'represents' in RIBType doc #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

route: fix spelling of 'represents' in RIBType doc #69

wants to merge 1 commit into from

Conversation

alifarooq0
Copy link
Contributor

@alifarooq0 alifarooq0 commented Apr 21, 2020

No description provided.

@alifarooq0 alifarooq0 changed the title net/route: fixed a typo in RIBType's comment route: fixed a typo in RIBType's comment Apr 21, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 5ada0f5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/229224 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 1: Code-Review+2

(1 comment)

Thank you for catching this Ali, and thanks for the sending this change!

Please update the commit message to the suggestion I've provided.

For that, you'll manually have to update the Github PR's description
and title.

Once ready, I shall then merge this in.


Please don’t reply on this GitHub thread. Visit golang.org/cl/229224.
After addressing review feedback, remember to publish your drafts!

@alifarooq0 alifarooq0 changed the title route: fixed a typo in RIBType's comment route: fix spelling of 'represents' in RIBType doc Apr 21, 2020
@gopherbot
Copy link
Contributor

Message from Ali Farooq:

Patch Set 2:

(1 comment)

Patch Set 1: Code-Review+2

(1 comment)

Thank you for catching this Ali, and thanks for the sending this change!

Please update the commit message to the suggestion I've provided.

For that, you'll manually have to update the Github PR's description
and title.

Once ready, I shall then merge this in.

Fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/229224.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 2:

Patch Set 2:

(1 comment)

Patch Set 1: Code-Review+2

(1 comment)

Thank you for catching this Ali, and thanks for the sending this change!

Please update the commit message to the suggestion I've provided.

For that, you'll manually have to update the Github PR's description
and title.

Once ready, I shall then merge this in.

Fixed.

Please remove the description part as it shows doubly now :) The title I guess is sufficient.


Please don’t reply on this GitHub thread. Visit golang.org/cl/229224.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ali Farooq:

Patch Set 2:

Patch Set 2:

Patch Set 2:

(1 comment)

Patch Set 1: Code-Review+2

(1 comment)

Thank you for catching this Ali, and thanks for the sending this change!

Please update the commit message to the suggestion I've provided.

For that, you'll manually have to update the Github PR's description
and title.

Once ready, I shall then merge this in.

Fixed.

Please remove the description part as it shows doubly now :) The title I guess is sufficient.

Whoops, this github->gerrit sync is funky :D Fixed now. The github repos, are they just for public and all internal development is done through internal git repos at Google?


Please don’t reply on this GitHub thread. Visit golang.org/cl/229224.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 21, 2020
Change-Id: I5f4ca1a70c90cfa5d8c95ef4d5e8fbfe7f855b1d
GitHub-Last-Rev: 5ada0f5
GitHub-Pull-Request: #69
Reviewed-on: https://go-review.googlesource.com/c/net/+/229224
Reviewed-by: Emmanuel Odeke <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/229224 has been merged.

@gopherbot gopherbot closed this Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants