-
Notifications
You must be signed in to change notification settings - Fork 1.2k
http2: remove unused addConn #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: a213978) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/230201 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/230201. |
Message from Brad Fitzpatrick: Patch Set 1: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/230201. |
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=a6af5881 Please don’t reply on this GitHub thread. Visit golang.org/cl/230201. |
`addConn` is dead code that's not used any more. `addConnLocked` is used when a new connection needs to be added to the connection pool, and the callers always manage the lock. Change-Id: I27d4a402e243a34f8ad707645738953764e05eb3 GitHub-Last-Rev: a213978 GitHub-Pull-Request: #70 Reviewed-on: https://go-review.googlesource.com/c/net/+/230201 Reviewed-by: Brad Fitzpatrick <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/230201. |
This PR is being closed because golang.org/cl/230201 has been merged. |
`addConn` is dead code that's not used any more. `addConnLocked` is used when a new connection needs to be added to the connection pool, and the callers always manage the lock. Change-Id: I27d4a402e243a34f8ad707645738953764e05eb3 GitHub-Last-Rev: a213978a8553bee95d60d31ca00e7f784d55ecd9 GitHub-Pull-Request: golang/net#70 Reviewed-on: https://go-review.googlesource.com/c/net/+/230201 Reviewed-by: Brad Fitzpatrick <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
addConn
is dead code that's not used any more.addConnLocked
is used when a new connectionneeds to be added to the connection pool, and the callers
always manage the lock.