-
Notifications
You must be signed in to change notification settings - Fork 1.2k
add http2 health check parameters for ConfigureTransport #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: duyanghao <[email protected]>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Signed-off-by: duyanghao <[email protected]>
This PR (HEAD: 664141a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/255178 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/255178. |
This seems duplicate of #74. |
(I don't mind abandoning #74 if you can get this one in :) |
I'd be delighted to do so as variadic function looks better. |
Signed-off-by: duyanghao <[email protected]>
This PR (HEAD: a9d7b68) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/255178 to see it. Tip: You can toggle comments from me using the |
@bradfitz Please take a look at this PR. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/255178. |
Currently,
ConfigureTransport
can't configure http2 health check parameters(i.e. http2.Transport.ReadIdleTimeout and http2.Transport.PingTimeout).This PR add http2 health check transportOption for ConfigureTransport when configures a net/http HTTP/1 Transport to use HTTP/2.
Signed-off-by: duyanghao [email protected]