-
Notifications
You must be signed in to change notification settings - Fork 1k
x/oauth2: make DeviceAuth retrieval populate RetrieveError #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 1f93366) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/709215. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/709215. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/709215. |
Message from Sean Liao: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/709215. |
This PR (HEAD: b15d789) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/709215. Important tips:
|
Endpoints may return errors when attempting to request device authorization. Currently, these error codes are ignored and an otherwise empty RetrieveError returned. This change populates the RetrieveError similar to the oauth2 token exchange. Fix golang/go#75759
This PR (HEAD: 8322f7f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/709215. Important tips:
|
Message from Andreas Goetz: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/709215. |
Message from Andreas Goetz: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/709215. |
Message from Andreas Goetz: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/709215. |
Endpoints may return errors when attempting to request device authorization. Currently, these error codes are ignored and an otherwise empty RetrieveError returned. This change populates the RetrieveError similar to the oauth2 token exchange.
Fix golang/go#75759