grpc code generator in v1.4.0 (and master) is outdated

[menghanl]

What version of protobuf and what language are you using?
v1.3.5, v1.4.0 and master

---

Latest commit on tag v1.4.0 is from Nov 2018

https://github.com/golang/protobuf/tree/v1.4.0/protoc-gen-go/grpc

---

Latest commit from v1.3.5 is from Jan 2020

https://github.com/golang/protobuf/tree/v1.3.5/protoc-gen-go/grpc

---

Master is missing commits, too

https://github.com/golang/protobuf/tree/master/protoc-gen-go/grpc

[dsnet]

The github.com/golang/protobuf/protoc-gen-go/grpc package is dead code. The underlying implementation for grpc is in github.com/golang/protobuf/internal/gengogrpc, which at the time created was a direct copy of the code in google.golang.org/protobuf/cmd/protoc-gen-go-grpc/internal_gengogrpc.

The commit you think is missing was simultaneously committed to the new implementation here.

[menghanl]

This will break users using grpc as a library (instead of using the binary generator). I'm verifying with the user now, in grpc/grpc-go#3591.

But even though using the library isn't expected, was there any particular reason to have outdated code there?
It's an exported package (probably should have been, but..), and I don't see any reason to break it.

[dsnet]

This will break users using grpc as a library (instead of using the binary generator).

If that's the case, then that use case is unfortunately unsupported. Any uses of generator as a library has explicitly been stated to be outside our compatibility policy. That said, we may consider making the grpc package identical to what it was in v1.3.5 even though it's on the chopping block for being removed in the future.