Skip to content

protoc-gen-go/grpc: service with no RPC methods no longer compiles #819

Closed
@Martin2112

Description

@Martin2112

Hi,

Just checking if this was an intentional change or something unsupported that's "just worked" by accident before. Our Travis builds just broke. We have a service like this:

service TrillianLogSequencer {}

The generated code no longer builds as of today but was OK last week:

../trillian_log_sequencer_api.pb.go:11:2: imported and not used: "google.golang.org/grpc/codes"
../trillian_log_sequencer_api.pb.go:12:2: imported and not used: "google.golang.org/grpc/status"

Example:

https://travis-ci.org/google/trillian/jobs/507856974

If I add a dummy RPC to the service the problem goes away.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions