Skip to content

ssh/terminal: add support for tamago #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ssh/terminal: add support for tamago #1

wants to merge 1 commit into from

Conversation

abarisani
Copy link

This commit broke use of ssh/terminal within GOOS=tamago.

In a manner similar to what has been done for zos this would fix that.

Thank you

@google-cla
Copy link

google-cla bot commented Nov 17, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 17, 2020
@abarisani
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 17, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 0e280a1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/term/+/270737 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/270737.
After addressing review feedback, remember to publish your drafts!

@empijei
Copy link

empijei commented Nov 17, 2020

cc @FiloSottile

@gopherbot
Copy link
Contributor

Message from Andrea Barisani:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/270737.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrea Barisani:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/270737.
After addressing review feedback, remember to publish your drafts!

@abarisani abarisani closed this Nov 17, 2020
@abarisani abarisani deleted the tamago branch November 17, 2020 15:35
ldemailly added a commit to ldemailly/term that referenced this pull request Aug 8, 2024
Expose History() AddToHistory() and NewHistory() so users of the library can save and restore the history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants