go/analysis/passes/printf: allow # for b flag #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

erikdubbelboer wants to merge 1 commit into golang:master from erikdubbelboer:binary-sharp

Contributor

erikdubbelboer commented Oct 28, 2019

Adding the # to a b flag is allowed and adds a leading 0b to the output.


          go/analysis/passes/printf: allow # for b flag

016896a

Adding the # to a b flag is allowed and adds a leading 0b to the output.

googlebot added the cla: yes label

Contributor

gopherbot commented Oct 28, 2019

This PR (HEAD: 016896a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/203798 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Oct 28, 2019

Message from Erik Dubbelboer:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/203798.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 29, 2019

Message from Michael Matloob:

Patch Set 1: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/203798.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 29, 2019

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e321812d

Please don’t reply on this GitHub thread. Visit golang.org/cl/203798.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 29, 2019

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on x/tools (linux-amd64):
See https://storage.googleapis.com/go-build-log/a0c1e8d1/linux-amd64_a6f55360.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/203798.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 29, 2019

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

8 of 10 TryBots failed:
Failed on x/tools (linux-amd64): https://storage.googleapis.com/go-build-log/a0c1e8d1/linux-amd64_a6f55360.log
Failed on x/tools (linux-386): https://storage.googleapis.com/go-build-log/a0c1e8d1/linux-386_aedf6fb7.log
Failed on x/tools (freebsd-amd64-12_0): https://storage.googleapis.com/go-build-log/a0c1e8d1/freebsd-amd64-12_0_03f013ae.log
Failed on x/tools (windows-amd64-2016): https://storage.googleapis.com/go-build-log/a0c1e8d1/windows-amd64-2016_702b1d83.log
Failed on x/tools (linux-amd64-race): https://storage.googleapis.com/go-build-log/a0c1e8d1/linux-amd64-race_7fedf11d.log
Failed on x/tools (openbsd-amd64-64): https://storage.googleapis.com/go-build-log/a0c1e8d1/openbsd-amd64-64_fda3ed2c.log
Failed on x/tools (windows-386-2008): https://storage.googleapis.com/go-build-log/a0c1e8d1/windows-386-2008_8073b38b.log
Failed on x/tools (android-amd64-emu): https://storage.googleapis.com/go-build-log/a0c1e8d1/android-amd64-emu_6029c4c9.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/203798.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 29, 2019

Message from Erik Dubbelboer:

Patch Set 1:

These failures have nothing do with my change.

Please don’t reply on this GitHub thread. Visit golang.org/cl/203798.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          go/analysis/passes/printf: allow # for b flag

288d118

Adding the `#` to a `b` flag is allowed and adds a leading `0b` to the output.

Change-Id: I421891f9478d1aaff2585455f38b3aa50e8277ab
GitHub-Last-Rev: 016896a
GitHub-Pull-Request: #182
Reviewed-on: https://go-review.googlesource.com/c/tools/+/203798
Reviewed-by: Erik Dubbelboer <[email protected]>
Reviewed-by: Michael Matloob <[email protected]>
Run-TryBot: Michael Matloob <[email protected]>

Contributor

gopherbot commented Oct 29, 2019

This PR is being closed because golang.org/cl/203798 has been merged.

gopherbot closed this

gopherbot pushed a commit that referenced this pull request


          [release-branch.go1.13] go/analysis/passes/printf: allow # for b flag

f713011

Adding the `#` to a `b` flag is allowed and adds a leading `0b` to the output.

For golang/go#39287.

Change-Id: I421891f9478d1aaff2585455f38b3aa50e8277ab
GitHub-Last-Rev: 016896a
GitHub-Pull-Request: #182
Reviewed-on: https://go-review.googlesource.com/c/tools/+/203798
Reviewed-by: Erik Dubbelboer <[email protected]>
Reviewed-by: Michael Matloob <[email protected]>
Run-TryBot: Michael Matloob <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237944
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels