-
Notifications
You must be signed in to change notification settings - Fork 2.3k
update jquery to 3.5.1 #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 8e38f85) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/253757 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/253757. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/253757. |
This PR (HEAD: 3352ea5) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/253757 to see it. Tip: You can toggle comments from me using the |
Can there be some movement on this? We're looking at having to pull the tools package from our code due to this issue. |
I've got the following, flagged against: |
Hey guys, what would it take to merge this PR? The vulnerability scanners go wild on jQuery prior 3.5.1 so it'd be great to fix it 👍 |
hey guys, do we have any ETA on merging this PR? Vulnerability scanners are flagging this dependency as a major issue |
The imported Gerrit change (https://go.dev/cl/253757) was abandoned. It's not clear to me why GopherBot did not also close this PR. If upgrading jQuery is needed for security reasons, I suggest reporting those reasons per https://go.dev/security/policy, and/or updating the discussion on golang/go#39535. |
Some Open Source vulnerabilities scanners will mark
golang.org/x/tools
as vulnerable because of the versions ofjquery
. Even if the vulnerable parts are not used, this can prevent some organizations of integratinggolang.org/x/tools
in their code because of it.