Skip to content

update jquery to 3.5.1 #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

andresperezl
Copy link

Some Open Source vulnerabilities scanners will mark golang.org/x/tools as vulnerable because of the versions of jquery. Even if the vulnerable parts are not used, this can prevent some organizations of integrating golang.org/x/tools in their code because of it.

@gopherbot
Copy link
Contributor

This PR (HEAD: 8e38f85) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/253757 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/253757.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/253757.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 3352ea5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/253757 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@atkinsonbg
Copy link

Can there be some movement on this? We're looking at having to pull the tools package from our code due to this issue.

@edrandall
Copy link

I've got the following, flagged against: /go/pkg/mod/golang.org/x/[email protected]/cmd/present/static/jquery-ui.js in image: golang:1.17.7

@ademidoff
Copy link

Hey guys, what would it take to merge this PR? The vulnerability scanners go wild on jQuery prior 3.5.1 so it'd be great to fix it 👍

@gmonni
Copy link

gmonni commented Dec 6, 2022

hey guys, do we have any ETA on merging this PR? Vulnerability scanners are flagging this dependency as a major issue

@bcmills
Copy link
Contributor

bcmills commented Dec 9, 2022

The imported Gerrit change (https://go.dev/cl/253757) was abandoned. It's not clear to me why GopherBot did not also close this PR.

If upgrading jQuery is needed for security reasons, I suggest reporting those reasons per https://go.dev/security/policy, and/or updating the discussion on golang/go#39535.

@bcmills bcmills closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants