go/tools: add check for time formats with 2006-02-01 #342

erikdubbelboer · 2021-10-05T17:25:51Z

yyyy-dd-mm is a time format that isn't really used anywhere [1]. It is
much more likely that the user intended to use yyyy-mm-dd instead and
made a mistake. This happens quite often [2] because of the unusual way
to handle time formatting and parsing in Go. Since the mistake is Go
specific and happens so often a vet check will be useful.

Updates golang/go#48801

gopherbot · 2021-10-05T17:42:27Z

This PR (HEAD: 378e8e6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/354010 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

timothy-king · 2021-10-05T17:48:49Z

Has a proposal been accepted for this? If not, please submit a proposal for the new vet checker. The process is documented here https://github.com/golang/proposal#the-proposal-process .

gopherbot · 2021-11-03T18:36:46Z

Message from Tim King:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-03T18:48:33Z

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-21T21:16:04Z

Message from Tim King:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-21T21:16:09Z

This PR (HEAD: 80add7a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/354010 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-04-21T21:54:45Z

Message from Tim King:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-21T21:58:34Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-21T21:58:35Z

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/b17d7487-6c31-4905-8bd6-dbcee1067eb6

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-21T21:58:36Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-21T22:02:31Z

Message from kokoro:

Patch Set 2: gopls-CI-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/b17d7487-6c31-4905-8bd6-dbcee1067eb6

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-21T22:06:34Z

Message from Gopher Robot:

Patch Set 2: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T07:42:01Z

This PR (HEAD: bc7a674) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/354010 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-04-22T15:58:21Z

Message from Erik Dubbelboer:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T16:02:23Z

Message from Robert Findley:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T16:02:24Z

Message from Gopher Robot:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T16:02:25Z

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/db8d2604-7422-4706-bbf5-a018d5e8f6e7

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T16:02:25Z

Message from Robert Findley:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T16:06:30Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T16:06:31Z

Message from kokoro:

Patch Set 3: gopls-CI-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/db8d2604-7422-4706-bbf5-a018d5e8f6e7

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T16:14:26Z

This PR (HEAD: 1c22f3b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/354010 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-04-22T16:18:29Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T16:18:29Z

Message from Erik Dubbelboer:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T17:57:32Z

Message from Tim King:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T17:57:33Z

Message from Gopher Robot:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-04-22T18:01:29Z

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/cbdd5b8d-fce0-4e9f-ac94-d9959527973b

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-06-08T22:56:10Z

Message from Tim King:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-07-02T07:37:35Z

This PR (HEAD: 5d16f99) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/354010 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-07-02T07:53:01Z

Message from Erik Dubbelboer:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-07-18T21:27:05Z

Message from Tim King:

Patch Set 12: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-07-19T12:08:27Z

This PR (HEAD: 1396411) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/354010 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-07-19T12:12:56Z

Message from Erik Dubbelboer:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-07-22T02:02:40Z

Message from Robert Findley:

Patch Set 13: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-07-22T02:06:31Z

Message from Gopher Robot:

Patch Set 13:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-07-22T02:06:31Z

Message from kokoro:

Patch Set 13:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/7224d2dc-2eb6-434c-9183-bdcd34958c15

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-07-22T02:14:14Z

Message from kokoro:

Patch Set 13: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/7224d2dc-2eb6-434c-9183-bdcd34958c15

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-07-22T02:21:51Z

Message from Gopher Robot:

Patch Set 13: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-07-22T15:34:03Z

This PR (HEAD: a717a0a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/354010 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-07-22T15:38:22Z

Message from Erik Dubbelboer:

Patch Set 13:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-07-22T15:42:41Z

Message from Robert Findley:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

yyyy-dd-mm is a time format that isn't really used anywhere [1]. It is much more likely that the user intended to use yyyy-mm-dd instead and made a mistake. This happens quite often [2] because of the unusual way to handle time formatting and parsing in Go. Since the mistake is Go specific and happens so often a vet check will be useful. 1. https://stackoverflow.com/questions/2254014/are-there-locales-or-common-programs-that-use-yyyy-dd-mm-as-the-date-format 2. https://github.com/search?l=&p=1&q=%222006-02-01%22+language%3AGo&type=Code Updates golang/go#48801

gopherbot · 2022-07-29T19:28:01Z

This PR (HEAD: 496b991) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/354010 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-07-29T19:32:10Z

Message from Erik Dubbelboer:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-03T03:17:11Z

Message from Tim King:

Patch Set 15: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-03T03:25:47Z

Message from Gopher Robot:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-03T03:25:47Z

Message from kokoro:

Patch Set 15:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/7d7b16e4-c82c-4a8c-a02e-2216b5978689

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-03T03:30:10Z

Message from kokoro:

Patch Set 15: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/7d7b16e4-c82c-4a8c-a02e-2216b5978689

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-03T03:34:34Z

Message from Gopher Robot:

Patch Set 15: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-03T03:38:59Z

Message from Robert Findley:

Patch Set 15: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/354010.
After addressing review feedback, remember to publish your drafts!

yyyy-dd-mm is a time format that isn't really used anywhere [1]. It is much more likely that the user intended to use yyyy-mm-dd instead and made a mistake. This happens quite often [2] because of the unusual way to handle time formatting and parsing in Go. Since the mistake is Go specific and happens so often a vet check will be useful. 1. https://stackoverflow.com/questions/2254014/are-there-locales-or-common-programs-that-use-yyyy-dd-mm-as-the-date-format 2. https://github.com/search?l=&p=1&q=%222006-02-01%22+language%3AGo&type=Code Updates golang/go#48801 Change-Id: I20960c93710766f20a7df90873bff960dea41b28 GitHub-Last-Rev: 496b991 GitHub-Pull-Request: #342 Reviewed-on: https://go-review.googlesource.com/c/tools/+/354010 gopls-CI: kokoro <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Tim King <[email protected]> Run-TryBot: Tim King <[email protected]> Reviewed-by: Robert Findley <[email protected]>

gopherbot · 2022-08-03T20:07:32Z

This PR is being closed because golang.org/cl/354010 has been merged.

google-cla bot added the cla: yes label Oct 5, 2021

erikdubbelboer mentioned this pull request Oct 5, 2021

cmd/vet: check for time formats with 2006-02-01 golang/go#48801

Closed

erikdubbelboer force-pushed the timeformat branch from 378e8e6 to 80add7a Compare April 21, 2022 21:13

erikdubbelboer force-pushed the timeformat branch from 80add7a to bc7a674 Compare April 22, 2022 07:40

erikdubbelboer force-pushed the timeformat branch from 77e7600 to 5d16f99 Compare July 2, 2022 07:33

erikdubbelboer force-pushed the timeformat branch from 5d16f99 to 1396411 Compare July 19, 2022 12:04

erikdubbelboer force-pushed the timeformat branch from 1396411 to a717a0a Compare July 22, 2022 15:31

erikdubbelboer force-pushed the timeformat branch from a717a0a to 496b991 Compare July 29, 2022 19:24

gopherbot closed this Aug 3, 2022

go/tools: add check for time formats with 2006-02-01 #342

go/tools: add check for time formats with 2006-02-01 #342

Conversation

erikdubbelboer commented Oct 5, 2021 • edited Loading

gopherbot commented Oct 5, 2021

timothy-king commented Oct 5, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Nov 3, 2021

gopherbot commented Apr 21, 2022

gopherbot commented Apr 21, 2022

gopherbot commented Apr 21, 2022

gopherbot commented Apr 21, 2022

gopherbot commented Apr 21, 2022

gopherbot commented Apr 21, 2022

gopherbot commented Apr 21, 2022

gopherbot commented Apr 21, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Apr 22, 2022

gopherbot commented Jun 8, 2022

gopherbot commented Jul 2, 2022

gopherbot commented Jul 2, 2022

gopherbot commented Jul 18, 2022

gopherbot commented Jul 19, 2022

gopherbot commented Jul 19, 2022

gopherbot commented Jul 22, 2022

gopherbot commented Jul 22, 2022

gopherbot commented Jul 22, 2022

gopherbot commented Jul 22, 2022

gopherbot commented Jul 22, 2022

gopherbot commented Jul 22, 2022

gopherbot commented Jul 22, 2022

gopherbot commented Jul 22, 2022

gopherbot commented Jul 29, 2022

gopherbot commented Jul 29, 2022

gopherbot commented Aug 3, 2022

gopherbot commented Aug 3, 2022

gopherbot commented Aug 3, 2022

gopherbot commented Aug 3, 2022

gopherbot commented Aug 3, 2022

gopherbot commented Aug 3, 2022

gopherbot commented Aug 3, 2022

erikdubbelboer commented Oct 5, 2021 •

edited

Loading