gopls: stubbed methods shouldn't qualify the current package #447

tttoad · 2023-08-08T08:46:05Z

google-cla · 2023-08-08T08:46:08Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2023-08-08T09:06:56Z

This PR (HEAD: 86b19da) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/516758.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-08T09:19:03Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-11T22:06:55Z

Message from Robert Findley:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T02:31:54Z

Message from t hepudds:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T02:47:38Z

Message from t hepudds:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T02:47:39Z

Message from t hepudds:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T02:53:03Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T02:53:04Z

Message from kokoro:

Patch Set 3:

Kokoro presubmit build queued for golang/tools/gopls-legacy/presubmit
Logs at: http://sponge2.corp.google.com/698226c6-152b-4f0b-b30e-b6fecd0935dd

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T02:53:05Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T02:58:18Z

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/698226c6-152b-4f0b-b30e-b6fecd0935dd

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T03:03:33Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T03:03:34Z

Message from kokoro:

Patch Set 3: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/698226c6-152b-4f0b-b30e-b6fecd0935dd

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T16:32:54Z

Message from Robert Findley:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T05:57:24Z

Message from kokoro:

Patch Set 4:

Kokoro presubmit build queued for golang/tools/gopls-legacy/presubmit
Logs at: http://sponge2.corp.google.com/140e2071-a747-4dd3-981f-ff86be1d6483

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T05:57:25Z

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/140e2071-a747-4dd3-981f-ff86be1d6483

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T05:57:31Z

This PR (HEAD: a667745) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/516758.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-18T06:08:24Z

Message from kokoro:

Patch Set 4: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/140e2071-a747-4dd3-981f-ff86be1d6483

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T09:16:01Z

Message from t hepudds:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T09:16:02Z

Message from Gopher Robot:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T09:16:03Z

Message from kokoro:

Patch Set 5:

Kokoro presubmit build queued for golang/tools/gopls-legacy/presubmit
Logs at: http://sponge2.corp.google.com/844bba1f-769d-43af-85d2-f5c2f1ba87fd

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T09:16:04Z

Message from kokoro:

Patch Set 5:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/844bba1f-769d-43af-85d2-f5c2f1ba87fd

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T09:27:07Z

Message from kokoro:

Patch Set 5: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/844bba1f-769d-43af-85d2-f5c2f1ba87fd

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T09:27:08Z

Message from Gopher Robot:

Patch Set 5: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T13:06:09Z

Message from Gopher Robot:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T13:12:12Z

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-18T13:29:51Z

Message from Robert Findley:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/516758.
After addressing review feedback, remember to publish your drafts!

Fixes golang/go#61830 Change-Id: I41aff8177b57d64a684cd11ff78aa7c4f00ce36c GitHub-Last-Rev: a667745 GitHub-Pull-Request: #447 Reviewed-on: https://go-review.googlesource.com/c/tools/+/516758 Reviewed-by: Robert Findley <[email protected]> Run-TryBot: t hepudds <[email protected]> gopls-CI: kokoro <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

gopherbot · 2023-08-18T14:00:07Z

This PR is being closed because golang.org/cl/516758 has been merged.

findleyr mentioned this pull request Aug 16, 2023

x/tools/gopls: Implement action should ignore importing the current package golang/go#61830

Closed

tttoad changed the title ~~gopls: Implement action should ignore importing the current package.~~ gopls: stubbed methods shouldn't qualify the current package Aug 17, 2023

fix: Ignore the current package.

a667745

tttoad force-pushed the fix-implement branch from 86b19da to a667745 Compare August 18, 2023 05:50

gopherbot closed this Aug 18, 2023

gopls: stubbed methods shouldn't qualify the current package #447

gopls: stubbed methods shouldn't qualify the current package #447

Uh oh!

Conversation

tttoad commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla bot commented Aug 8, 2023

Uh oh!

gopherbot commented Aug 8, 2023

Uh oh!

gopherbot commented Aug 8, 2023

Uh oh!

gopherbot commented Aug 11, 2023

Uh oh!

gopherbot commented Aug 17, 2023

Uh oh!

gopherbot commented Aug 17, 2023

Uh oh!

gopherbot commented Aug 17, 2023

Uh oh!

gopherbot commented Aug 17, 2023

Uh oh!

gopherbot commented Aug 17, 2023

Uh oh!

gopherbot commented Aug 17, 2023

Uh oh!

gopherbot commented Aug 17, 2023

Uh oh!

gopherbot commented Aug 17, 2023

Uh oh!

gopherbot commented Aug 17, 2023

Uh oh!

gopherbot commented Aug 17, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

gopherbot commented Aug 18, 2023

Uh oh!

Uh oh!

tttoad commented Aug 8, 2023 •

edited

Loading