Skip to content

gopls/internal/settings: correct SemanticTokenTypes source #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gopls/internal/settings: correct SemanticTokenTypes source #564

wants to merge 1 commit into from

Conversation

danztran
Copy link
Contributor

@gopherbot
Copy link
Contributor

This PR (HEAD: c81d388) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/652655.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/652655.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/652655.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hongxiang Jiang:

Patch Set 1: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/652655.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-26T16:06:24Z","revision":"dc463e1b7685df7c109b5bf93343c9352128c046"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/652655.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hongxiang Jiang:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/652655.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hongxiang Jiang:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/652655.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/652655.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/652655.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/652655.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 26, 2025
@danztran @gopherbot
gopls/internal/settings: correct SemanticTokenTypes source
d740adf 
fix golang/go#71964

Change-Id: I2694023636272ea971880865a4f2cb6d9192d7d5
GitHub-Last-Rev: c81d388
GitHub-Pull-Request: #564
Reviewed-on: https://go-review.googlesource.com/c/tools/+/652655
Reviewed-by: Hongxiang Jiang <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
Auto-Submit: Hongxiang Jiang <[email protected]>
@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-26T17:50:44Z","revision":"ddc4bd55332ab2e7c8274a74f907a1b8d8cfef69"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/652915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-arm64 has failed with summary (view all results):

Build or test failure, click here for results.

To reproduce, try gomote repro 8721850457012694465.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/652915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/652915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-26T18:34:58Z","revision":"ddc4bd55332ab2e7c8274a74f907a1b8d8cfef69"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/652915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-arm64-boringcrypto has failed with summary (view all results):

Build or test failure, click here for results.

To reproduce, try gomote repro 8721847675193006065.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/652915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-26T20:51:17Z","revision":"00e077860dc72bf04b1354ea02cf770bd2ca169e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/652915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Copied votes on follow-up patch sets have been updated:

  • LUCI-TryBot-Result-1 has been copied to patch set 3 (copy condition: "changekind:NO_CODE_CHANGE").

Please don’t reply on this GitHub thread. Visit golang.org/cl/652915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-26T20:52:01Z","revision":"a3e4a442cf5d0b957663f9c8a0001e76a8876c16"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/652915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/652915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/652915.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/652915.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 26, 2025
@danztran @h9jiang
[gopls-release-branch.0.18] gopls/internal/settings: correct Semantic…
c6ad2fe 
…TokenTypes source

fix golang/go#71964

Change-Id: I2694023636272ea971880865a4f2cb6d9192d7d5
GitHub-Last-Rev: c81d388
GitHub-Pull-Request: #564
Reviewed-on: https://go-review.googlesource.com/c/tools/+/652655
Reviewed-by: Hongxiang Jiang <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
Auto-Submit: Hongxiang Jiang <[email protected]>
(cherry picked from commit d740adf)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/652915
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/652915 has been merged.

@gopherbot gopherbot closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/tools/gopls: setting semanticTokenTypes has no effect
2 participants
@danztran @gopherbot