-
Notifications
You must be signed in to change notification settings - Fork 2.3k
go/analysis/passes/shadow: separate package-level variables logic #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 498fb53) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/694037. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/694037. |
Message from Boris Kreitchman: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/694037. |
Message from Boris Kreitchman: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/694037. |
Message from Alan Donovan: Patch Set 2: (9 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/694037. |
498fb53
to
d7e5d6e
Compare
This PR (HEAD: d7e5d6e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/694037. Important tips:
|
Message from Boris Kreitchman: Patch Set 3: (10 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/694037. |
Message from Alan Donovan: Patch Set 3: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/694037. |
Message from Boris Kreitchman: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/694037. |
Span-based shadow detection across multiple files may produce inconsistent
results due to changes in filename ordering and map iteration. Since only
package-level variables can be shadowed cross-file, this PR handles them
separately using usage-based detection.
Fixes golang/go#40758
Continues from #583