Skip to content

src/goLanguageServer: enforce minimum version requirement even when checkForUpdates is off #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hyangah opened this issue Mar 13, 2021 · 2 comments
Open

src/goLanguageServer: enforce minimum version requirement even when checkForUpdates is off #1334

hyangah opened this issue Mar 13, 2021 · 2 comments
Milestone
vscode-go/unplanned

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 13, 2021

There are cases where the backwards compatibility is not feasible (e.g. #1300).
Even though we have a minimum version hard-coded, currently the version check logic is completely skipped if users configured to use checkForUpdates : off.

vscode-go/src/goLanguageServer.ts

Line 1013 in 7dac4c7

if (tool.name !== 'gopls' || cfg.checkForUpdates === 'off' || IsInCloudIDE) {

Either enforce that, or clearly communicate with users about the risk.
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/302832 mentions this issue: src/goLanguageServer: always check the version before crash report

gopherbot pushed a commit that referenced this issue Mar 18, 2021
@hyangah
src/goLanguageServer: always check the version before crash report
73e7c36 
For dev-version, we still not enforce update (this case should be
clear enough to tell apart from the gopls version included in the
issue report and is valuable to detect crash report during dev
period).

And
 - Add go version used by the extension and the update flag info.
 - Update gopls latestVersion to v0.6.8.

Updates #1300
Updates #1334
Updates #1338

Change-Id: I9965297b164665056dbec68285eb740ec2908f01
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/302832
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/303051 mentions this issue: [release] src/goLanguageServer: always check the version before crash report

gopherbot pushed a commit that referenced this issue Mar 19, 2021
@hyangah
[release] src/goLanguageServer: always check the version before crash…
e5c7441 
… report

For dev-version, we still not enforce update (this case should be
clear enough to tell apart from the gopls version included in the
issue report and is valuable to detect crash report during dev
period).

And
 - Add go version used by the extension and the update flag info.
 - Update gopls latestVersion to v0.6.8.

Updates #1300
Updates #1334
Updates #1338

Change-Id: I9965297b164665056dbec68285eb740ec2908f01
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/302832
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
(cherry picked from commit 73e7c36)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/303051
@hyangah hyangah mentioned this issue Mar 31, 2021
Closed
@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@stamblerre stamblerre modified the milestones: Untriaged, Backlog Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vscode-go/unplanned
Development

No branches or pull requests
3 participants
@hyangah @stamblerre @gopherbot