bug: unable to determine `go version` with Go installed using Snap

[eqinox76]

What version of Go, VS Code & VS Code Go extension are you using?

• Run go version to get version of Go
  • go version go1.14.4 linux/amd64
• Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders
  • 1.45.1
    5763d909d5f12fe19f215cbfdd29a91c0fa9208a
    x64
• Check your installed extensions to get the version of the VS Code Go extension
  • 0.14.3
• Run go env to get the go development environment details
  • GO111MODULE=""
    GOARCH="amd64"
    GOBIN=""
    GOCACHE="/home/carsten/.cache/go-build"
    GOENV="/home/carsten/.config/go/env"
    GOEXE=""
    GOFLAGS=""
    GOHOSTARCH="amd64"
    GOHOSTOS="linux"
    GOINSECURE=""
    GONOPROXY=""
    GONOSUMDB=""
    GOOS="linux"
    GOPATH="/home/carsten/go"
    GOPRIVATE=""
    GOPROXY="https://proxy.golang.org,direct"
    GOROOT="/snap/go/5830"
    GOSUMDB="sum.golang.org"
    GOTMPDIR=""
    GOTOOLDIR="/snap/go/5830/pkg/tool/linux_amd64"
    GCCGO="gccgo"
    AR="ar"
    CC="gcc"
    CXX="g++"
    CGO_ENABLED="1"
    GOMOD="/home/carsten/projects/TickImporter/go.mod"
    CGO_CFLAGS="-g -O2"
    CGO_CPPFLAGS=""
    CGO_CXXFLAGS="-g -O2"
    CGO_FFLAGS="-g -O2"
    CGO_LDFLAGS="-g -O2"
    PKG_CONFIG="pkg-config"
    GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build126575450=/tmp/go-build -gno-record-gcc-switches"

Share the Go related settings you have added/edited

    "go.gopath": "~/go",
    "go.useLanguageServer": true,
    "go.addTags": {
    },
    "[go]": {
        "editor.formatOnSave": true,
        "editor.codeActionsOnSave": {
            "source.organizeImports": true,
        },
        // Optional: Disable snippets, as they conflict with completion ranking.
        "editor.snippetSuggestions": "none",
    },
    "[go.mod]": {
        "editor.formatOnSave": true,
        "editor.codeActionsOnSave": {
            "source.organizeImports": true,
        },
    },
    "gopls": {
         // Add parameter placeholders when completing a function.
        "usePlaceholders": true,
    
        // If true, enable additional analyses with staticcheck.
        // Warning: This will significantly increase memory usage.
        "staticcheck": false,
    },
    "go.lintTool": "golangci-lint",
    "go.testFlags": ["-v"]

Describe the bug

Using the 'run test' annotation or the Go: Test Package does nothing.

Steps to reproduce the behavior:

1. Open any file with unittests
2. Click on 'run test'
3. See Output in Go Tests

Running tool: /snap/bin/go test -timeout 30s -coverprofile=/tmp/vscode-go5Q7PrY/go-code-cover -v

The output of gopls and go show no issues.

Running this exact command via the commandline works fine. Also from the terminal within vscode.

Checking the developer tools i only see the following warning:

[Extension Host] console.ts:137
Not able to determine version from the output of the command "/snap/bin/go version": 

When i watch the Process Explorer closely i see the the go test process starting and a subprocess for the linker for a very short time. I did not manage to capture a screenshot.

I am running ubuntu 20.04 and have go and vscode installed via snap. I am using gopls as can be seen in the config above.

Any hints how i can debug this issue further?

[hyangah]

@eqinox76 What is the output of /snap/bin/go version if you run it from the command line?

[eqinox76]

Hey @hyangah

$ /snap/bin/go version
go version go1.14.4 linux/amd64
$ which go
/snap/bin/go

[eqinox76]

I am not sure if snap is the issue here. Checking the version string from the official docker container is looks the same:

$ docker run --rm golang go version
go version go1.14.4 linux/amd64

The log message may be a red hering. As the tooling installation, code completion, etc. is working fine.

[stamblerre]

We've actually had a few reports of people using Snap and having issues with the go version check. It's strange because it does look like the correct output. I'll spend some time investigating this when I have a chance.

[dim]

Does it maybe have something to do with the way snap is aliasing binaries?

$ whereis go
go: /snap/bin/go /snap/bin/go.gofmt
$ go version
go version go1.14.7 linux/amd64
$ ls -l /snap/bin/go
lrwxrwxrwx 1 root root 13 Aug 12 15:45 /snap/bin/go -> /usr/bin/snap

[gopherbot]

Change https://golang.org/cl/248858 mentions this issue: src/util.ts: log go version output

[hyangah]

Do you still see the issue with the latest version of the extension? From the log included in the original report, it looks like when the go extension ran /snap/bin/go version command, it got an empty result but no stderr or error that triggered an exception. Not sure how to repro this case.
Added the logging back that was removed at some point.

[dim]

I have manually applied your patch above to my local instance, here are the outputs:

[2020-08-18 09:13:23.931] [exthost] [info] ExtensionService#_doActivateExtension golang.go {"startup":true,"extensionId":{"value":"golang.go","_lower":"golang.go"},"activationEvent":"workspaceContains:**/*.go"}
[2020-08-18 09:13:23.931] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/dim/.vscode/extensions/golang.go-0.16.1/dist/goMain.js
[2020-08-18 09:13:23.999] [exthost] [info] eager extensions activated

[Extension Host] unable to determine version from the output of "/snap/bin/go version": ""
t.log @ /snap/code/40/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:266
[Extension Host] cached Go version ({"binaryPath":"/snap/bin/go","version":""}) is invalid, recomputing
t.log @ /snap/code/40/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:266
[Extension Host] unable to determine version from the output of "/snap/bin/go version": ""

[dim]

I am not sure how the version outputs differ:

$ /snap/bin/go version
go version go1.14.7 linux/amd64
$ /usr/local/go/bin/go version
go version go1.15 linux/amd64

Could it be because both go and vscode are both installed as snaps that one cannot exec the other?

[dim]

Sorry, any leads on that one? It's really quite an annoying bug.

[hyangah]

@dim Sorry, I am not familiar with Snap's permission and security model.

We can disable all the go version related logic when go version is empty. But I am afraid this is just the tip of the iceberg.

In the original report -

The output of gopls and go show no issues.
--> What does that mean? Do you see the gopls trace from the OUTPUT > gopls (server) channel?

Running this exact command via the commandline works fine. Also from the terminal within vscode.
--> Does it mean the go test output is empty, and test didn't run?

I suspect the extension is not able to run the go command at all.
If the command worked fine in the vscode integrated terminal, can you check

1. is invoking other tools from a vscode extension host permitted in Snap's security model?
2. Are the vscode's integrated terminal and the extension host seeing the same set of environment variables? They may differ because when starting integrated terminal, vscode may run .profile, .bash_profile, .bashrc, ...
   For the integrated terminal, the usual command env.
   For the vscode extension host, open the developer window by running Developers: Toggle Developer Tools -> From 'Console', enter "process.env".

[dim]

@hyangah sorry, I may not have all the answers on the snap security model as I am neither particularly familiar with it, but following your advise:

1. none of the other tools seem to be affected
2. output of process.env is the same as the output of env in a non vscode terminal, I doubt that's the culprit

As explained before, in the Go channel, I can only see this:

unable to determine version from the output of "/snap/bin/go version": ""
cached Go version ({"binaryPath":"/snap/bin/go","version":""}) is invalid, recomputing

Running version command manually inside the vscode terminal seems to yield correct results:

$ go version
go version go1.14.7 linux/amd64
$ /snap/bin/go version
go version go1.14.7 linux/amd64

I am not sure what else I should check. If it helps, I am more than happy to apply another manual patch to ~/.vscode/extensions/golang.go-0.16.1/dist/goMain.js to extract more debug info?