Skip to content

Sync @ 7da5077 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Sync @ 7da5077 #11

wants to merge 5 commits into from

Conversation

hyangah
Copy link
Contributor

@hyangah hyangah commented Mar 16, 2020 •
edited
Loading

Merge 'microsoft/vscode-go/master' into 'golang/vscode-go/master'

Sync @ 7da5077

* master:
  Address mismatch on path separators in debug config (#2010) (#3108)
  Include the link to release note/package overview in the update prompt, and update gopls default version (#3041)
  bug_report.md: Fix "architecture" typo. (#3095)
  telemetry.ts: send telemetry only if aiKey is not an empty  string(#3091)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Mar 16, 2020
quoctruong and others added 2 commits March 19, 2020 12:55
@quoctruong
Address mismatch on path separators in debug config (microsoft#2010) (m…
7da5077 
…icrosoft#3108)
@hyangah
Merge 'microsoft/vscode-go/master' into 'golang/vscode-go/master'
d11e342 
Sync @ 7da5077

* master:
  Address mismatch on path separators in debug config (microsoft#2010) (microsoft#3108)
  Include the link to release note/package overview in the update prompt, and update gopls default version (microsoft#3041)
  bug_report.md: Fix "architecture" typo. (microsoft#3095)
  telemetry.ts: send telemetry only if aiKey is not an empty  string(microsoft#3091)
@hyangah hyangah changed the title Sync @6d1bf5c Sync @ 7da5077 Mar 19, 2020
@hyangah hyangah added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 20, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Mar 20, 2020
@hyangah
Copy link
Contributor Author

hyangah commented Mar 20, 2020 •
edited
Loading

Removed cla:no manually because this is a simple merge commit that keeps this repo in sync with the upstream.

@gopherbot
Copy link
Collaborator

This PR (HEAD: d11e342) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/224239 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request Mar 20, 2020
@hyangah
Sync @ 7da5077
19896f5 
 Merge 'microsoft/vscode-go/master' into 'golang/vscode-go/master'

    Sync @ 7da5077

    * master:
      Address mismatch on path separators in debug config (#2010) (#3108)
      Include the link to release note/package overview in the update prompt, and update gopls default version (#3041)
      bug_report.md: Fix "architecture" typo. (#3095)
      telemetry.ts: send telemetry only if aiKey is not an empty  string(#3091)

Change-Id: I727ef0ed3b8d1ad926e26831534c153b06070e64
GitHub-Last-Rev: d11e342
GitHub-Pull-Request: #11
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/224239
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/224239 has been merged.

@gopherbot gopherbot closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hyangah @googlebot @gopherbot @darkvertex @quoctruong