-
Notifications
You must be signed in to change notification settings - Fork 797
add support for multi-file test suite #2314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: acf6939) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/415894 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/415894. |
Message from Hyang-Ah Hana Kim: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415894. |
This PR (HEAD: ea33226) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/415894 to see it. Tip: You can toggle comments from me using the |
ea33226
to
bc7d469
Compare
This PR (HEAD: bc7d469) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/415894 to see it. Tip: You can toggle comments from me using the |
Message from Nir Haas: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415894. |
bc7d469
to
39bbf4f
Compare
This PR (HEAD: 39bbf4f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/415894 to see it. Tip: You can toggle comments from me using the |
Message from Hyang-Ah Hana Kim: Patch Set 4: Run-TryBot+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415894. |
Message from kokoro: Patch Set 4: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/415894. |
Message from kokoro: Patch Set 4: TryBot-Result-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/415894. |
When evaluating whether a symbol is a document or not, check if testify was imported by any file of the directory (which is the go package). Fixes golang#1130
39bbf4f
to
efc72ad
Compare
This PR (HEAD: efc72ad) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/415894 to see it. Tip: You can toggle comments from me using the |
Message from Nir Haas: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/415894. |
Message from Hyang-Ah Hana Kim: Patch Set 5: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/415894. |
Message from kokoro: Patch Set 5: Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/415894. |
Message from kokoro: Patch Set 5: TryBot-Result+1 Kokoro presubmit build finished with status: SUCCESS Please don’t reply on this GitHub thread. Visit golang.org/cl/415894. |
Message from Michael Knyszek: Patch Set 5: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/415894. |
When collecting tests or evaluating whether a symbol is a test for CodeLens, check if testify was imported by any file of the directory (which is the go package). Not sure whether this is the optimal / recommended way of dealing with this, but here goes. Fixes #1130 Change-Id: I4e66f0d319604a7300116240c24b60dcdd37bf81 GitHub-Last-Rev: efc72ad GitHub-Pull-Request: #2314 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/415894 TryBot-Result: kokoro <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Michael Knyszek <[email protected]>
This PR is being closed because golang.org/cl/415894 has been merged. |
When collecting tests or evaluating whether a symbol is a test for CodeLens, check if testify was imported by any file of the directory (which is the go package).
Not sure whether this is the optimal / recommended way of dealing with this, but here goes.
Fixes #1130