Skip to content

_content/doc/tutorial: fix inaccuracies in workspace tutorial #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

BernhardValenti
Copy link
Contributor

the first change is related to: golang/go#51449

@google-cla
Copy link

google-cla bot commented Mar 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@gopherbot
Copy link
Contributor

This PR (HEAD: f8d2854) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/389638 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/389638.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/389638.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e19bc97) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/389638 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bernhard Valenti:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/389638.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/389638.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 2: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/389638.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 2: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/389638.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 31, 2022
the first change is related to: golang/go#51449

Change-Id: I857d412a5082b142bb54d7fab685d298488376f9
GitHub-Last-Rev: e19bc97
GitHub-Pull-Request: #136
Reviewed-on: https://go-review.googlesource.com/c/website/+/389638
Reviewed-by: Michael Matloob <[email protected]>
Trust: Michael Matloob <[email protected]>
Trust: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/389638 has been merged.

@gopherbot gopherbot closed this Mar 31, 2022
@BernhardValenti BernhardValenti deleted the workspace-tutorial-fixes branch March 31, 2022 06:22
MK825 added a commit to MK825/website that referenced this pull request Oct 18, 2022
the first change is related to: golang/go#51449

Change-Id: I857d412a5082b142bb54d7fab685d298488376f9
GitHub-Last-Rev: e19bc97f9bfe5d64213af262a8c1d744cddedca8
GitHub-Pull-Request: golang/website#136
Reviewed-on: https://go-review.googlesource.com/c/website/+/389638
Reviewed-by: Michael Matloob <[email protected]>
Trust: Michael Matloob <[email protected]>
Trust: Ian Lance Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants