Skip to content

embedded errcheck linter errors are not the same as with running standalone errcheck  #1194

@hellt

Description

@hellt

Hi, thanks for creating this gh action

I receive inconsistent results with this action considering the errcheck linter. If I run the latest errcheck downloaded with go get I receive an extensive report, whereas running golang-ci-lint action with default configuration I see just a fraction of errcheck linter errors.
What could be the potential reason? This is my test run log:

2020-06-21T07:53:29.1627489Z Running [/home/runner/golangci-lint-1.27.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
2020-06-21T07:53:30.6448589Z ##[error]Error return value of `reqCapability` is not checked (errcheck)
2020-06-21T07:53:30.6452862Z ##[error]Error return value of `viper.BindPFlag` is not checked (errcheck)
2020-06-21T07:53:30.6453512Z ##[error]Error return value of `getCmd.MarkFlagRequired` is not checked (errcheck)
2020-06-21T07:53:30.6454304Z ##[error]Error return value of `viper.BindPFlag` is not checked (errcheck)
2020-06-21T07:53:30.6454990Z ##[error]Error return value of `viper.BindPFlag` is not checked (errcheck)
2020-06-21T07:53:30.6455423Z ##[error]Error return value of `server.grpcServer.Serve` is not checked (errcheck)
2020-06-21T07:53:30.6455859Z ##[error]Error return value of `viper.ReadInConfig` is not checked (errcheck)
2020-06-21T07:53:30.6456332Z ##[error]Error return value of `subscribeCmd.MarkFlagRequired` is not checked (errcheck)

and the output of the errcheck is far more complete for the same commit https://gist.github.com/hellt/9f02f6c8a2e768fb3d9d25cbcb6f432b

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions