Unable to install using script from goreleaser.com

[subosito]

Installing golangci-lint using script from goreleaser.com, failed:

•|• curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh
golangci/golangci-lint info checking GitHub for latest tag
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/darwin/amd64
•/• echo $?
1

While using fallback script, it works fine:

•|• curl -sfL https://github.com/raw/golangci/golangci-lint/master/install.sh| sh
golangci/golangci-lint info checking GitHub for latest tag
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/darwin/amd64
golangci/golangci-lint info installed ./bin/golangci-lint
•|• echo $?
0
•|• ./bin/golangci-lint --version
golangci-lint has version 1.17.1 built from 4ba2155 on 2019-06-10T09:07:35Z

[ivantedja]

Somehow the script from goreleaser doesn't have BINARY variable

[flimzy]

A temporary work-around, to get your CI pipline working again immediately, is to update your install command:

curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | BINARY=golangci-lint sh -s -- -b $(go env GOPATH)/bin v1.17.1

Note the addition of the BINARY=golang-ci variable after the pipe (|) character.

[iliapolo]

@flimzy

A temporary work-around, to get your CI pipline working again immediately, is to update your install command:

curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | BINARY=golangci-lint sh -s -- -b $(go env GOPATH)/bin v1.17.1

Note the addition of the BINARY=golang-ci variable after the pipe (|) character.

While this does the trick, I wonder if a different approach is better.

I noticed that the install.sh in github does contain the variable, which means that the script in goreleaser.com somehow diverged from the one here.

To avoid these things, and actually use a static version of the script for reproducible builds, I changed the URL to simply point to a specific tag in this repo.

i.e https://github.com/raw/golangci/golangci-lint/v1.16.0/install.sh

What do you think?

I'd appreciate one of the maintainers to confirm this is a valid approach, just to make sure I can rely on this tag to be frozen and contain all the necessary installation features as the script in goreleaser.com does.

[pierrre]

@iliapolo I like this approach.
It would allow reproducible build.
It could be great if goreleaser could support that too.