You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The gocyclo upstream seems to abandoned a long time ago. There are open issues and PRs that never get any feedback.
What do you think about create a maintained fork of it ?
@trajber, @OrBaruk That would be fantastic! The first preference is always to upstream changes as much as possible but when that isn't possible the changes can be forked by the project or included directly which is the case for some linters like dogsled, lll, nakedret, etc. If you take a look at the go.mod file you can see which linters have been forked to include additions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Activity
tpounds commentedon Sep 29, 2019
@trajber There is already a project fork at https://github.com/golangci/gocyclo. Are you asking to have those prs merged in there?
OrBaruk commentedon Oct 7, 2019
Hi, I work with @trajber and the what we are interested in getting merged is the PR fzipp/gocyclo#27 for the issue fzipp/gocyclo#19
We weren't aware of the the fork used by golangci-lint if there is interest I can open this PR on https://github.com/golangci/gocyclo
tpounds commentedon Oct 7, 2019
@trajber, @OrBaruk That would be fantastic! The first preference is always to upstream changes as much as possible but when that isn't possible the changes can be forked by the project or included directly which is the case for some linters like
dogsled
,lll
,nakedret
, etc. If you take a look at the go.mod file you can see which linters have been forked to include additions.OrBaruk commentedon Oct 8, 2019
@tpounds Created golangci/gocyclo#3
stale commentedon Apr 5, 2020
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
update go-critic