Skip to content

feat: new linters configuration #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 1, 2025
Merged

feat: new linters configuration #5475

merged 8 commits into from
Mar 1, 2025

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 25, 2025 •
edited
Loading

The documentation will be added in another PR.

Fixes #5299
Fixes #1909

@ldez ldez added enhancement New feature or improvement area: config Related to .golangci.yml and/or cli options labels Feb 25, 2025
@ldez ldez added this to the v2-unreleased milestone Feb 25, 2025
@ldez ldez requested review from alexandear and bombsimon February 25, 2025 18:52
@ldez ldez force-pushed the feat/new-linter-cfg branch from 5df8766 to f924710 Compare February 25, 2025 18:55
@ldez ldez force-pushed the feat/new-linter-cfg branch from a8d43c7 to ed47d6f Compare February 26, 2025 02:02
alexandear
alexandear reviewed Feb 26, 2025
View reviewed changes
bombsimon
bombsimon approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to keep you waiting without much of a review but don't have much to add! Added a question but probably me missing something.

LGTM! ⭐

@ldez ldez merged commit 60ac0dd into golangci:main Mar 1, 2025
18 checks passed
@ldez ldez deleted the feat/new-linter-cfg branch March 1, 2025 20:21
@ldez ldez mentioned this pull request Mar 4, 2025
Closed
4 tasks
@busser busser mentioned this pull request Mar 14, 2025
Closed
@ldez ldez modified the milestones: v2-unreleased, v2 Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

@alexandear alexandear alexandear approved these changes

Assignees
No one assigned
Labels
area: config Related to .golangci.yml and/or cli options enhancement New feature or improvement
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

🌟 Let's talk about linters section of the configuration The --fast flag does not overwrite the configuration file
3 participants
@ldez @alexandear @bombsimon