Skip to content

Conversation

soniah
Copy link
Contributor

@soniah soniah commented Jun 6, 2019

Squashing commits and doing PR off master not dev branch (versus #540)

@soniah soniah mentioned this pull request Jun 6, 2019
@soniah
Copy link
Contributor Author

soniah commented Jun 6, 2019

Sorry, I don't know how to fix "Can't run golangci-lint: internal error, see build log"

@jirfag
Copy link
Contributor

jirfag commented Jun 9, 2019

thank you!

@jirfag jirfag merged commit 5c86bfc into golangci:master Jun 9, 2019
@glenjamin
Copy link
Contributor

This does seem to produce a valid junit XML file, but none of the tests are marked as failures, so CircleCI doesn't detect that it's supposed to display the errors.

See #373 for some links with more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants