Skip to content

Speed up packages loading #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2019
Merged

Speed up packages loading #693

merged 1 commit into from
Sep 14, 2019

Conversation

jirfag
Copy link
Contributor

@jirfag jirfag commented Sep 14, 2019

Don't perform extra go env calls in go/packages.
Load only needed go env vars in golangci-lint.
Stay in sync by enabled analyzers in go vet: remove nilness and
atomicalign analyzers, add errorsas analyzer.
Don't build SSA for govet.

Standalone govet runs 25% faster than before. All runs can be 5-10% faster
than before.
Relates: #208

Don't perform extra go env calls in go/packages.
Load only needed go env vars in golangci-lint.
Stay in sync by enabled analyzers in go vet: remove nilness and
atomicalign analyzers, add errorsas analyzer.
Don't build SSA for govet.

Standalone govet runs 25% faster than before. All runs can be 5-10% faster
than before.
Relates: #208
@jirfag jirfag merged commit c9a9255 into master Sep 14, 2019
@jirfag jirfag deleted the feature/speed-up-govet branch September 14, 2019 15:48
@ernado
Copy link
Member

ernado commented Sep 14, 2019

Is there a way to enable the atomicalign back?
UPD: will be available after #697

@ldez ldez added this to the v1.19 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants