Skip to content
This repository was archived by the owner on Jun 2, 2023. It is now read-only.

Can't run golangci-lint: invalid output json, see build log #54

Closed
vthiery opened this issue Oct 14, 2019 · 3 comments
Closed

Can't run golangci-lint: invalid output json, see build log #54

vthiery opened this issue Oct 14, 2019 · 3 comments

Comments

@vthiery
Copy link
Contributor

vthiery commented Oct 14, 2019

We're getting when golangci scans our repositories, with the following logs:

GOLANGCI_COM_RUN=1 golangci-lint run --out-format=json --issues-exit-code=0 --deadline=5m --new=false --new-from-rev= --new-from-patch=../changes.patch
    Flag --deadline has been deprecated, flag will be removed soon, please, use .golangci.yml config
    {"Issues":null,"Report":{"Linters":[{"Name" [...]

I guess the output containing the non-JSON line Flag --deadline has been deprecated, flag will be removed soon, please, use .golangci.yml is problematic.

I raised the PR #53 to attempt to fix the issue. I also updated the flag in golangci-api with golangci/golangci-api#152.

@jirfag
Copy link
Collaborator

jirfag commented Oct 14, 2019

fixed and released, thank you!

please, check

@jirfag jirfag closed this as completed Oct 14, 2019
@vthiery
Copy link
Contributor Author

vthiery commented Oct 15, 2019

I'm actually still getting this error. Could it be that the container golangci/build-runner was not updated?

@vthiery
Copy link
Contributor Author

vthiery commented Oct 15, 2019

It just got updated (cf https://hub.docker.com/r/golangci/build-runner/tags) and the scans now work. So all good :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants