-
Notifications
You must be signed in to change notification settings - Fork 152
feat: Add inputAudioTranscription support to Java ADK #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jinnigu
wants to merge
1
commit into
google:main
Choose a base branch
from
jinnigu:feature/inputAudioTranscription
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+179
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
core/src/test/java/com/google/adk/runner/InputAudioTranscriptionTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| /* | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.adk.runner; | ||
|
|
||
| import static com.google.adk.testing.TestUtils.createLlmResponse; | ||
| import static com.google.adk.testing.TestUtils.createTestAgentBuilder; | ||
| import static com.google.adk.testing.TestUtils.createTestLlm; | ||
| import static com.google.common.truth.Truth.assertThat; | ||
|
|
||
| import com.google.adk.agents.InvocationContext; | ||
| import com.google.adk.agents.LiveRequestQueue; | ||
| import com.google.adk.agents.LlmAgent; | ||
| import com.google.adk.agents.RunConfig; | ||
| import com.google.adk.sessions.Session; | ||
| import com.google.adk.testing.TestLlm; | ||
| import com.google.common.collect.ImmutableList; | ||
| import com.google.genai.types.AudioTranscriptionConfig; | ||
| import com.google.genai.types.Content; | ||
| import com.google.genai.types.Modality; | ||
| import com.google.genai.types.Part; | ||
| import java.lang.reflect.Method; | ||
| import java.util.Optional; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.JUnit4; | ||
|
|
||
| @RunWith(JUnit4.class) | ||
| public final class InputAudioTranscriptionTest { | ||
|
|
||
| private Content createContent(String text) { | ||
| return Content.builder().parts(Part.builder().text(text).build()).build(); | ||
| } | ||
|
|
||
| private InvocationContext invokeNewInvocationContextForLive( | ||
| Runner runner, Session session, LiveRequestQueue liveRequestQueue, RunConfig runConfig) | ||
| throws Exception { | ||
| Method method = | ||
| Runner.class.getDeclaredMethod( | ||
| "newInvocationContextForLive", Session.class, Optional.class, RunConfig.class); | ||
| method.setAccessible(true); | ||
| return (InvocationContext) | ||
| method.invoke(runner, session, Optional.of(liveRequestQueue), runConfig); | ||
| } | ||
|
|
||
| @Test | ||
| public void newInvocationContextForLive_multiAgent_autoConfiguresInputAudioTranscription() | ||
| throws Exception { | ||
| TestLlm testLlm = createTestLlm(createLlmResponse(createContent("response"))); | ||
| LlmAgent subAgent = createTestAgentBuilder(testLlm).name("sub_agent").build(); | ||
| LlmAgent rootAgent = | ||
| createTestAgentBuilder(testLlm) | ||
| .name("root_agent") | ||
| .subAgents(ImmutableList.of(subAgent)) | ||
| .build(); | ||
|
|
||
| Runner runner = new InMemoryRunner(rootAgent, "test", ImmutableList.of()); | ||
| Session session = runner.sessionService().createSession("test", "user").blockingGet(); | ||
|
|
||
| RunConfig initialConfig = | ||
| RunConfig.builder() | ||
| .setResponseModalities(ImmutableList.of(new Modality(Modality.Known.AUDIO))) | ||
| .setStreamingMode(RunConfig.StreamingMode.BIDI) | ||
| .build(); | ||
|
|
||
| assertThat(initialConfig.inputAudioTranscription()).isNull(); | ||
|
|
||
| LiveRequestQueue liveQueue = new LiveRequestQueue(); | ||
| InvocationContext context = | ||
| invokeNewInvocationContextForLive(runner, session, liveQueue, initialConfig); | ||
|
|
||
| assertThat(context.runConfig().inputAudioTranscription()).isNotNull(); | ||
| } | ||
|
|
||
| @Test | ||
| public void newInvocationContextForLive_explicitConfig_preservesUserInputAudioTranscription() | ||
| throws Exception { | ||
| TestLlm testLlm = createTestLlm(createLlmResponse(createContent("response"))); | ||
| LlmAgent subAgent = createTestAgentBuilder(testLlm).name("sub_agent").build(); | ||
| LlmAgent rootAgent = | ||
| createTestAgentBuilder(testLlm) | ||
| .name("root_agent") | ||
| .subAgents(ImmutableList.of(subAgent)) | ||
| .build(); | ||
|
|
||
| Runner runner = new InMemoryRunner(rootAgent, "test", ImmutableList.of()); | ||
| Session session = runner.sessionService().createSession("test", "user").blockingGet(); | ||
|
|
||
| AudioTranscriptionConfig userConfig = AudioTranscriptionConfig.builder().build(); | ||
| RunConfig configWithUserSetting = | ||
| RunConfig.builder() | ||
| .setResponseModalities(ImmutableList.of(new Modality(Modality.Known.AUDIO))) | ||
| .setStreamingMode(RunConfig.StreamingMode.BIDI) | ||
| .setInputAudioTranscription(userConfig) | ||
| .build(); | ||
|
|
||
| LiveRequestQueue liveQueue = new LiveRequestQueue(); | ||
| InvocationContext context = | ||
| invokeNewInvocationContextForLive(runner, session, liveQueue, configWithUserSetting); | ||
|
|
||
| assertThat(context.runConfig().inputAudioTranscription()).isSameInstanceAs(userConfig); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jinnigu The inline comment and the code don't seem to align, here? The "text" says "apply modality defaults" but then this removes
!CollectionUtils.isNullOrEmpty(runConfig.responseModalities()... is that intentional? (It may well be, I'm entirely sure about why this was originally like this; but it seems worth double checking.) Also, why would we limit transcription only for multi-agent live scenarios? I would personally love to use this even for a very simple trivial only-LlmAgent use case... you speak to it, and get a persistent transcript in your session store, that's very cool! I'd love to use this e.g. in my (personal) https://docs.enola.dev project - but don't see why it needs to be limited to work only if!this.agent.subAgents().isEmpty().There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why I made the change like this is because I want to make adk-java equivalent to adk-python (https://github.com/google/adk-python/blob/main/src/google/adk/runners.py#L939-L971). I also agree that we should not limit transcription to multi-agent live scenarios only. I will raise an issue in adk-python to gather some feedbacks and make PRs to both adk-python and adk-java.