-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Expose OOM event count to prometheus #2829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @kragniz. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm not convinced this is the best way to get the event data through, but seemed like the most straightforward. If this is an acceptable method, I can add tests and tidy this up further. |
/assign @bobbypage |
b6703b4
to
0de3d6e
Compare
@iwankgb thanks for the reviews, I've updated with fixes |
/ok-to-test |
/retest |
0de3d6e
to
fa07332
Compare
This metric (Docker) always returns 0 for me - see also #3015 |
Fixes #1837.