Skip to content

Implement containerd environment variables whitelisting #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2021
Merged

Implement containerd environment variables whitelisting #2857

merged 1 commit into from
May 9, 2021

Conversation

skgsergio
Copy link
Contributor

@skgsergio skgsergio commented Apr 29, 2021

Currently, when using cadvisor with containerd it exposes all the environment variables for every container which can be dangerous (i.e. secret env vars in k8s) and can result in big and slow metrics responses (/metrics endpoint in our environment takes some seconds to reply and gives a >500MB body size) and high memory usage.

This PR adds the whitelisting functionality mimicking the same functionality in the docker module to keep consistency between them.

@google-cla google-cla bot added the cla: yes label Apr 29, 2021
@k8s-ci-robot
Copy link
Collaborator

Hi @skgsergio. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iwankgb
Copy link
Collaborator

iwankgb commented May 7, 2021

/ok-to-test

@iwankgb iwankgb merged commit fd868a8 into google:master May 9, 2021
@skgsergio skgsergio deleted the containerd/add-environment-variables-whitelisting branch June 16, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants