Skip to content

Initial Korean commit #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Initial Korean commit #276

wants to merge 3 commits into from

Conversation

joosangkim
Copy link

Initial commit Korean translation discussed on #262

@qwandor qwandor requested a review from mgeisler January 25, 2023 10:40
@mgeisler
Copy link
Collaborator

Hi @joosangkim, thanks a lot! Do you work with @keispace on this?

@mgeisler mgeisler changed the title korean initial commit Initial Korean commit Jan 25, 2023
@mgeisler
Copy link
Collaborator

Hi again, I just looked at the build step which runs msgfmt on the translation and it says

$ msgfmt --statistics -o /dev/null po/ko.po
30 translated messages, 1723 untranslated messages

In the ko.zip file from #130 (comment), we have 461 translated strings (and 333 "fuzzy" strings which need someone to look at them). This file is based on @keispace's work.

If you didn't see the file, I would love for you to combine the two ko.po files. You can use msgcat for this.

@joosangkim
Copy link
Author

joosangkim commented Jan 26, 2023

Hi @keispace . Thanks for translating https://google.github.io/comprehensive-rust/ into Korean first. Unfortunately, you and I have both worked on the same spot. What I've done on this PR is merging your translations and fixing templating issue(msgfmt) following @mgeisler 's comments above.


#: src/SUMMARY.md:22
msgid "Compile Time Guarantees"
msgstr "컴파일 시점의 보증성"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컴파일 시 보장되는 것들


#: src/SUMMARY.md:23
msgid "Runtime Guarantees"
msgstr "런타임 보증성"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

런타임 시 보장되는 것들


#: src/SUMMARY.md:28
msgid "References"
msgstr "참고"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

참조


#: src/SUMMARY.md:30
msgid "Slices"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

슬라이스


#: src/SUMMARY.md:31
msgid "String vs str"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String 과 str의 차이점


#: src/SUMMARY.md:29
msgid "Dangling References"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

허상(dangling) 참조


#: src/SUMMARY.md:33 src/SUMMARY.md:80
msgid "Methods"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메서드


#: src/SUMMARY.md:34
msgid "Overloading"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오버로딩


#: src/SUMMARY.md:36
msgid "Implicit Conversions"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

묵시적 변환


#: src/SUMMARY.md:37
msgid "Arrays and for Loops"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배열과 for 반복문

"generics\n"
"and error handling. It also includes Android-specific content on the last "
"day."
msgstr "이 과정은 Android team 에서 개발한 4 일 간의 Rust 과정입니다.\n이 과정은 Rust 의 기본 문법 부터 제네릭과 에러 처리와 같은 고급 주제를 다루고 있습니다.\n또한 마지막 날에 안드로이드에 특화된 내용을 다룹니다."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안드로이드 팀


#: src/SUMMARY.md:4
msgid "Running the Course"
msgstr "과정 진행하기"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/과정/강좌/ throughout the translations

"**application** \n"
"development in Rust, and that the Android-specific parts are specifically "
"about\n"
"writing code for Android itself, the operating system. "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust로 안드로이드 어플리케이션 개발하는 것은 이 강좌에서 다루지 않습니다. 이 강좌에서 다루는 안드로이드 특화된 내용은 안드로이드 운영체제의 일부를 Rust로 개발하는 것에 대한 것입니다.


#: src/SUMMARY.md:46
#: src/SUMMARY.md:44
msgid "Stack vs Heap"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스택과 힙

msgid "Move Semantics"
msgstr ""
msgstr "의미 이동"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"move 문법" sounds better and is inline with translations found for C++.

"의미 이동" means "moving of meaning".

msgid "Moved Strings in Rust"
msgstr ""
msgstr "러스트의 이동된 문자열"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

러스트에서 문자열의 이동

msgid "Copying and Cloning"
msgstr ""
msgstr "복사와 복제"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy와 Clone의 차이 ... because "Copy" and "Clone" have specific meanings in Rust.

msgid "Shared and Unique Borrows"
msgstr ""
msgstr "공유와 고유 빌림"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빌림의 두 종류: 공유 혹은 단독

msgid "Lifetimes in Data Structures"
msgstr ""
msgstr "자료 구조에서의 수명"
Copy link
Collaborator

@jiyongp jiyongp Jan 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구조체에서의 수명

msgid "Designing a Library"
msgstr ""
msgstr "도서관 설계"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

라이브러리 설계

@keispace
Copy link
Contributor

keispace commented Jan 26, 2023

Hi @keispace . Thanks for translating https://google.github.io/comprehensive-rust/ into Korean first. Unfortunately, you and I have both worked on the same spot. What I've done on this PR is merging your translations and fixing templating issue(msgfmt) following @mgeisler 's comments above.

@joosangkim
Hello, I am currently working on google/main modifications as of January 25th after the full translation draft has been completed. Not yet done but working if needed (fuzzy part needs to be worked) I'll share the branch. You can refer to the ko.po file.

@mgeisler
My translation work will be completed around tomorrow, but I'm not sure if it's right for several Korean translation PRs to go up.


안녕하세요. 관심있는 분이 또 계시니 반갑네요. 저는 현재 전체 번역 초안이 완료 되고 1월 25일 기준으로 google/main 수정사항을 작업 중입니다. 아직 완료는 되지 않았지만 필요하시면 작업중인(fuzzy 부분 및 4일차 키노트 미완료) 저장소 공유드리겠습니다. ko.po 파일 참고하시면 될거 같습니다.

제 번역 작업은 내일 쯤 완료 될텐데 한국어 번역 PR이 여러개 올라가는게 맞는지 모르겠네요

msgid "Method Receiver"
msgstr ""
msgstr "메서드 인자"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메서드 리시버... because receiver is not an ordinary argument(인자)

msgid "Health Statistics"
msgstr ""
msgstr "건강상태 통계"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헬스 모니터링 시스템

msgid "String"
msgstr ""

#: src/SUMMARY.md:106
#: src/SUMMARY.md:104
msgid "Option and Result"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option과 Result


#: src/SUMMARY.md:111
#: src/SUMMARY.md:109
msgid "Niche Optimization"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

소소한 최적화

msgid "Paths"
msgstr ""
msgstr "경로"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a type name. Let's not translate.

msgid "Traits"
msgstr ""
msgstr "트레이트"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특성(trait)

msgid "Deriving Traits"
msgstr ""
msgstr "트레이트 파생"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특성 상속하기

msgid "Important Traits"
msgstr ""
msgstr "중요 트레이트"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중요한 특정(trait)들


#: src/SUMMARY.md:133
#: src/SUMMARY.md:130
msgid "From and Into"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From과 Into

msgid "Read and Write"
msgstr ""

#: src/SUMMARY.md:135
#: src/SUMMARY.md:132
msgid "Add, Mul, ..."
msgstr ""

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

msgid "From and Into"
msgstr ""

#: src/SUMMARY.md:134
#: src/SUMMARY.md:131
msgid "Read and Write"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

msgid "impl Trait"
msgstr ""
msgstr "트레이트"
Copy link
Collaborator

@jiyongp jiyongp Jan 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특성 구현하기

msgid "Catching Stack Unwinding"
msgstr ""
msgstr "스택 해제 추적"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스택 되감기

msgid "Deriving Error Enums"
msgstr ""
msgstr "파생 오류 열거형"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

또다른 오류 열거형 타입

msgid "Documentation Tests"
msgstr ""
msgstr "문서 테스트"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석을 이용한 테스팅

msgid "Dereferencing Raw Pointers"
msgstr ""
msgstr "원시포인트 역참조"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

포인터 따라가기

I agree with https://yong-it.blogspot.com/2016/09/dereference.html

msgid "Mutable Static Variables"
msgstr ""
msgstr "정적 가변 변수"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경 가능한 정적 변수

msgid "Mutex"
msgstr ""

#: src/SUMMARY.md:188
#: src/SUMMARY.md:185
msgid "Send and Sync"
msgstr ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add 와

msgid "Build Rules"
msgstr ""
msgstr "빌드 규칙"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빌드 모듈 타입

Copy link
Collaborator

@jiyongp jiyongp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added suggestions for the titles.

@jiyongp
Copy link
Collaborator

jiyongp commented Jan 26, 2023

안녕하세요. 관심있는 분이 또 계시니 반갑네요. 저는 현재 전체 번역 초안이 완료 되고 1월 25일 기준으로 google/main 수정사항을 작업 중입니다. 아직 완료는 되지 않았지만 필요하시면 작업중인(fuzzy 부분 및 4일차 키노트 미완료) 저장소 공유드리겠습니다. ko.po 파일 참고하시면 될거 같습니다.

제 번역 작업은 내일 쯤 완료 될텐데 한국어 번역 PR이 여러개 올라가는게 맞는지 모르겠네요

I am a Korean software engineer working for Android @ Google. mgeisler invited me to review this translation. By the way, since we are chasing a moving target, I think we better submit this commit as is and fix the remaining issues separately as follow-ups.

@mgeisler
Copy link
Collaborator

@mgeisler
My translation work will be completed around tomorrow, but I'm not sure if it's right for several Korean translation PRs to go up.

Hi @keispace, I agree — it's cool to see that many people are interested 😄 However, we should focus on getting your first draft committed! Thank you again for the huge work you've done here.

@joosangkim, thank you also for your work. I think we should pause this PR until we have the changes from @keispace. I'm sorry about the duplication, I hope we caught it before you invested too much time here. Perhaps you can help @keispace with keeping the translation up to date as we make small changes to the course going forward?

keispace added a commit to keispace/comprehensive-rust-kr that referenced this pull request Jan 27, 2023
keispace added a commit to keispace/comprehensive-rust-kr that referenced this pull request Jan 27, 2023
@keispace keispace mentioned this pull request Jan 27, 2023
@mgeisler
Copy link
Collaborator

Thanks @keispace for opening #290! I believe we can close this PR now and then concentrate on fixing any remaining small issues in the Korean translation after #290 is merged.

@mgeisler mgeisler closed this Jan 27, 2023
@jiyongp jiyongp mentioned this pull request Jan 30, 2023
jiyongp added a commit that referenced this pull request Jan 30, 2023
* add ko.po

* translate ko(~23.01.19)

* change speaker-note ko

* change id

* translate ko(~23.01.20)

* ~day3 keynote

* draft done to f3446a9

* add @jiyongp comments of upstream PR #276.

* sync & apply review comments(upstream)

sync 585509b

* After 10000 line apply review comments(upstream)

* chgange build.yml

* Fix the inconsistent newline character problem for the KO translation

If a msgid does not end with the newline character, so should the
msgstr.

Test: msgfmt --statistics -o /dev/null po/ko.po
No error, but shows `1085 translated messages, 675 untranslated
messages.`

---------

Co-authored-by: Evan kim(cli) <[email protected]>
NoahDragon pushed a commit to wnghl/comprehensive-rust that referenced this pull request Jul 19, 2023
* add ko.po

* translate ko(~23.01.19)

* change speaker-note ko

* change id

* translate ko(~23.01.20)

* ~day3 keynote

* draft done to f3446a9

* add @jiyongp comments of upstream PR google#276.

* sync & apply review comments(upstream)

sync 585509b

* After 10000 line apply review comments(upstream)

* chgange build.yml

* Fix the inconsistent newline character problem for the KO translation

If a msgid does not end with the newline character, so should the
msgstr.

Test: msgfmt --statistics -o /dev/null po/ko.po
No error, but shows `1085 translated messages, 675 untranslated
messages.`

---------

Co-authored-by: Evan kim(cli) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants