In a fdl.Config for a dataclass, when accessing a field that uses a default_factory, populate a child Config (if not already present) wrapping the default_factory call, rather than raising a "Can't get default value for dataclass field ... since it uses a default_factory" error. #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_737952148
branch
from
6aad4cb to
5b69651
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_737952148
branch
from
5b69651 to
b0a0dd2
Compare
…efault_factory, populate a child Config (if not already present) wrapping the default_factory call, rather than raising a "Can't get default value for dataclass field ... since it uses a default_factory" error. This allows easy overriding of properties of child dataclasses, without requiring extra boilerplate in all parent configs to explicitly configure the defaults for child dataclasses. PiperOrigin-RevId: 737952148
copybara-service
bot
force-pushed
the
test_737952148
branch
from
b0a0dd2 to
14b4026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a fdl.Config for a dataclass, when accessing a field that uses a default_factory, populate a child Config (if not already present) wrapping the default_factory call, rather than raising a "Can't get default value for dataclass field ... since it uses a default_factory" error.
This allows easy overriding of properties of child dataclasses, without requiring extra boilerplate in all parent configs to explicitly configure the defaults for child dataclasses.