Add a copy constructor for the layout parameters #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| flexGrow = source.flexGrow; | ||
| flexShrink = source.flexShrink; | ||
| alignSelf = source.alignSelf; | ||
| flexBasisPercent = source.flexBasisPercent; |
There was a problem hiding this comment.
Please copy other fields as well.
(minWidth/minHeight, maxWidth/maxHeight, wrapBefore)
There was a problem hiding this comment.
Sorry about that, I'll fix it
There was a problem hiding this comment.
Thanks. When you do so, please squash the commit into the previous one.
|
Thanks! Could you copy other fields as well? |
abarisain
force-pushed
the
copy-constructor
branch
from
bec9401 to
88602ac
Compare
abarisain
force-pushed
the
copy-constructor
branch
from
88602ac to
f4301cd
Compare
|
It should be good. Sorry about the forgotten fields! |
|
LGTM! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the base LayoutParams and ViewGroup's implement a copy constructor, which is handy for a lot of cases.
Calling the copy constructor on FlexboxLayout.LayoutParams does not produce the expected result: parent properties are properly copied, but any FlexboxLayout specific attribute is ignored.
This pull requests adds a new copy constructor to FlexboxLayout's LayoutParams, making it behave as expected.