[linux/windows] Separate out a C channel API #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates PluginRegistrar and BinaryMessenger from the embedder.h API surface, moving them up to the FlutterWindowController level. In their place, adds new low-level messaging APIs, which are based closely on the Flutter engine embedder APIs (including an equivalent message struct), in some cases wrapping them directly. Unlike the engine APIs, they allow per-channel callbacks, so individual plugins can use the API. Since PluginHandler is no longer the source of truth for callback registration, only an adaptor, it's now fine to have multiple instances of them, all passing through to the underlying C API. Part of google#230
|
I'll need to add the new file to Windows, which I'll do tomorrow, but that won't affect the code (unless there are Windows-specific build issues, but I'm not expecting that) so it can be reviewed before then. |
franciscojma86
approved these changes
Jan 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates PluginRegistrar and BinaryMessenger from the embedder.h API
surface, moving them up to the FlutterWindowController level. In their
place, adds new low-level messaging APIs, which are based closely on
the Flutter engine embedder APIs (including an equivalent message
struct), in some cases wrapping them directly. Unlike the engine APIs,
they allow per-channel callbacks, so individual plugins can use the API.
Since PluginHandler is no longer the source of truth for callback
registration, only an adaptor, it's now fine to have multiple instances
of them, all passing through to the underlying C API.
Part of #230