Update macOS code for the plugin API rename #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FLEPlugin* was renamed FlutterPlugin*; this updates all the runner and plugin code for that change.
|
Hi all! The Travis build seems to be failing due to it not using the latest flutter. Do you think you can merge this? |
The Travis build failed (expectedly) at the time this PR was posted because the engine change linked in the description hadn't been rolled into Flutter.
Now that the roll has happened, yes; that was the point of having this PR ready. Landing it before the roll happened would have made it impossible for anyone to build with the latest version of this repository (against any version of Flutter). |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLEPlugin* was FlutterPlugin* in flutter/engine#9074
This updates all the runner and plugin code for that change.