File file_chooser macOS view reference #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The registrar is not guaranteed to have a view at registration time, and in practice no longer does causing file_chooser to have a nil view. It should instead be storing the registrar, and getting the view on demand. Fixes google#633
franciscojma86
approved these changes
Jan 21, 2020
|
Out of curiosity, do we know what changed to cause the registrar not to have a view at registration time? (I'm pretty sure this is a recent regression.) |
|
Probably flutter/engine#9750 |
|
Oh, huh, that's much longer ago than I thought. Thanks for fixing :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registrar is not guaranteed to have a view at registration time, and
in practice no longer does causing file_chooser to have a nil view. It
should instead be storing the registrar, and getting the view on demand.
Fixes #633