-
Notifications
You must be signed in to change notification settings - Fork 24
[wip] Add Android plugin for Text #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
and moved android impl folder from top level pkg
We should probably move the app in example down a layer since the text plugin includes things like text classification, language detector, and text embedding. |
Do you think it's important to have separate samples for each work flow, or could they potentially be lumped into one demo with 3 different buttons to complete each task? |
I'd keep them separated. We have one example per task in the other
platforms, so keeping them separated helps us add examples for each over
time
…On Mon, May 29, 2023, 9:37 AM Craig Labenz ***@***.***> wrote:
We should probably move the app in example down a layer since the text
plugin includes things like text classification, language detector, and
text embedding.
Do you think it's important to have separate samples for each work flow,
or could they potentially be lumped into one demo with 3 different buttons
to complete each task?
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR2C36XATQY2PTMPOG6DITXIS7B3ANCNFSM6AAAAAAYEIC7VI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Also let's keep it simple and only have one sample to start per category. For Android we did text classification, audio classification, and object detection. We can flesh out the remainders via GSoC and my own development once we have a rough template so you're not spending all of your time on samples. Core functionality is definitely the priority, and I can focus on details/polish. |
The latest commit should be working (or at least close to) from an implementation standpoint, but I'm getting segfault-like errors in my Android emulator. |
So obsolete, you can't even imagine. |
Description
Adds the beginning scaffolding for the
mediapipe_task_text
library, including themediapipe_task_text_platform_implementation
andmediapipe_task_text_android
libraries.Checklist
///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?