add support for github actions #364
Conversation
|
@polina-c (or @jamesderlin) - can you see if you can enable github actions to run for this PR? I'd like to see what breaks. |
|
visibility_detector should be in decent shape after my PR. I'd suggest adding actions for each repo specifically though - that way the UI will be clearer about which package fails, if any do. |
Yeah, this PR is just hooking back up the old travis script. Using a matrix build however - one per package - would give us better package visibility. |
.github/workflows/build.yaml
Outdated
| - uses: actions/checkout@v3 | ||
| - uses: subosito/[email protected] | ||
| with: | ||
| channel: 'stable' |
There was a problem hiding this comment.
Does this mean that it's going to test against Flutter's stable channel?
I think the Git repository should be testing against the master channel since Google internally consumes these packages via Git + copybara and tries to stay current with Flutter's master branch.
There was a problem hiding this comment.
If we do get this PR landed, we can revisit it to run against master and stable - a matrix of jobs for [packages] x [stable, master].
There was a problem hiding this comment.
visibility_detector will not pass on stable after #367 - it's intentionally using new API that was created for the refactor.
I'm not sure how to do that. |
|
It looks like the admins are: @chingjun, @jiahaog, @mehmetf, @xster and @zhenqiu1101. |
|
I apparently have merge access and am willing to merge it and to see what happens, but I'd much prefer that it test against |
switch testing to test against the `master` flutter channel
sgtm! Updated to test against |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: subosito/[email protected] |
There was a problem hiding this comment.
Hmm, maybe this should have been v2.4.0?
I'm not sure what'll break here; I'll create this as a draft PR for now.