Skip to content

With removal of deprecated client.Rate in #555, rate limit info needs more visibility #571

Closed
@gmlewis

Description

@gmlewis

It used to be that clients might make API calls like:

	repos, resp, err := client.Repositories.ListByOrg(org, opt)
	if err != nil {
		rate := client.Rate()
		if rate.Remaining == 0 {
			//...
		}
		//...
	}

but after #555, it turns out that checkRateLimitBeforeDo will return an error without rate information.
I have a PR on the way that addresses this issue.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions