Skip to content

Update Protected Branches API preview with Admin Enforcement #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gmlewis opened this issue Mar 30, 2017 · 2 comments
Closed

Update Protected Branches API preview with Admin Enforcement #606

gmlewis opened this issue Mar 30, 2017 · 2 comments
Labels
good first issue

Comments

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 30, 2017

GitHub Announcement:
https://developer.github.com/changes/2017-03-22-protected-branches-admin-improvements/

This will be a breaking API change and the package version will need to be bumped.
@amirilovic
Copy link
Contributor

@gmlewis I can take this.

amirilovic added a commit to amirilovic/go-github that referenced this issue Apr 1, 2017
@amirilovic
Add admin enforcement to protected branches API (google#606)
c00eead
@amirilovic amirilovic mentioned this issue Apr 1, 2017
Merged
dmitshur pushed a commit that referenced this issue Apr 21, 2017
@amirilovic @dmitshur
Add admin enforcement to protected branches API. (#610)
2966f25 
This change adds support for an addition to the Protected Branches API
preview, the ability to turn on and off admin settings in one place.

This is documented at https://developer.github.com/changes/2017-03-22-protected-branches-admin-improvements/.

The IncludeAdmins fields are deprecated, but they're still required to
be sent in the request for now. A future update to API preview will
remove the IncludeAdmins fields completely.

Helps #606.
bubg-dev pushed a commit to bubg-dev/go-github that referenced this issue Jun 16, 2017
@amirilovic @dmitshur
Add admin enforcement to protected branches API. (google#610)
03955a4 
This change adds support for an addition to the Protected Branches API
preview, the ability to turn on and off admin settings in one place.

This is documented at https://developer.github.com/changes/2017-03-22-protected-branches-admin-improvements/.

The IncludeAdmins fields are deprecated, but they're still required to
be sent in the request for now. A future update to API preview will
remove the IncludeAdmins fields completely.

Helps google#606.
@gmlewis
Copy link
Collaborator Author

gmlewis commented Jun 22, 2017

Let's close this issue and continue any discussion related to Protected Branches API in #617.

@gmlewis gmlewis closed this as completed Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amirilovic @gmlewis