Skip to content

Remove custom media type for Repository Invitations API #708

Closed
@gmlewis

Description

@gmlewis

GitHub Announcement:
https://developer.github.com/changes/2017-08-23-repository-invitation-api/

The custom media type mediaTypeRepositoryInvitationsPreview that was added in #373 can now be removed as it is no longer necessary.

Edit: ~~~GitHub Enterprise API customers may wish to comment on this issue if they feel that this removal should be delayed for any reason.~~~

Activity

RaviTezu

RaviTezu commented on Aug 24, 2017

@RaviTezu
Contributor

Hi @gmlewis Can I take this?

gmlewis

gmlewis commented on Aug 24, 2017

@gmlewis
CollaboratorAuthor

I just talked to @willnorris who reminded me that we will not be removing any features until we get confirmation that the removal won't break Enterprise API clients... so please hold off on addressing this issue.

Also, semantic versioning, once we nail that down for this repo, should assist with this situation.

See #376, #617, and #638 for further discussion.

RaviTezu

RaviTezu commented on Aug 24, 2017

@RaviTezu
Contributor
kshitij10496

kshitij10496 commented on Dec 19, 2017

@kshitij10496
Contributor

I can take this up next if @RaviTezu is not currently working on it.

gmlewis

gmlewis commented on Dec 19, 2017

@gmlewis
CollaboratorAuthor

Please see my comment above. We need confirmation from GitHub Enterprise API customers that the removal will not break them, which has happened in the past. Alternatively, semantic versioning needs to be adhered to in this repo before proceeding with this issue.

knrt10

knrt10 commented on Dec 11, 2018

@knrt10
Contributor

@gmlewis is this issue still blocked? If not I would like to work on this.

gmlewis

gmlewis commented on Dec 11, 2018

@gmlewis
CollaboratorAuthor

This issue is no longer blocked thanks to versioning. Feel free to take it, @knrt10.

knrt10

knrt10 commented on Dec 11, 2018

@knrt10
Contributor

Would you please assign me.

gmlewis

gmlewis commented on Dec 11, 2018

@gmlewis
CollaboratorAuthor

You first need to be sent an invite, @knrt10, and @willnorris can send you one when he has a chance.

In the meantime, however, please consider this issue to be assigned to you.
Others will see that in this comment section.

added a commit that references this issue on Dec 13, 2018
8c4c7c1
added a commit that references this issue on Oct 2, 2020
11a568b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @RaviTezu@gmlewis@kshitij10496@knrt10

        Issue actions

          Remove custom media type for Repository Invitations API · Issue #708 · google/go-github