Support preview Nested Teams API #714
Comments
|
I'd like to start working on this. |
|
Awesome, thanks @e-beach! |
|
As Glenn said, this doesn't have to be resolved in a single PR if that would make it large. If so, it'd be better to break it into a few smaller independent changes, as long as that's possible and doing so makes sense. |
|
I will be creating a I also noticed that the |
Create mediaTypeNestedTeamsPreview const for https://developer.github.com/changes/2017-08-30-preview-nested-teams/. Add parent field to the Team struct. Set preview API media type in endpoints that return a team, so that the new parent field gets populated. Helps #714.
Create mediaTypeNestedTeamsPreview const for https://developer.github.com/changes/2017-08-30-preview-nested-teams/. Add parent field to the Team struct. Set preview API media type in endpoints that return a team, so that the new parent field gets populated. Helps google#714.
This replaces Team with NewTeam in function that accept a team for creating or editing a team. The NewTeam struct is similar to the existing NewPullRequest for creating pull requests. We need a new struct because the set of parameters for creating or editing a team contains some parameters that are not in the parameter for teams, and most properties of teams cannot be used for editing. The specific change is that Teams are returned with a parent field, but are created/edited with a parent_id field. Helps #714.
|
@e-beach Is there anything left to implement? I'm wondering when the branch can be merged to master, and I'm glad to jump in to help if needed. |
|
@alindeman Thanks for the ping. Yes, #741 finished up support for the API, and this can be merged. |
|
OK, merging NestedTeamsPreview branch to master. See #747. |
Create mediaTypeNestedTeamsPreview const for https://developer.github.com/changes/2017-08-30-preview-nested-teams/. Add parent field to the Team struct. Set preview API media type in endpoints that return a team, so that the new parent field gets populated. Helps #714.
This replaces Team with NewTeam in function that accept a team for creating or editing a team. The NewTeam struct is similar to the existing NewPullRequest for creating pull requests. We need a new struct because the set of parameters for creating or editing a team contains some parameters that are not in the parameter for teams, and most properties of teams cannot be used for editing. The specific change is that Teams are returned with a parent field, but are created/edited with a parent_id field. Helps #714.
|
Merging got sidetracked - checking on status with @elliott-beach. Meanwhile, there is a new GitHub API announcement: This means that around line 34 of // Default is "secret".should be changed to: // Default is "closed".This documentation change can happen in a separate PR. |
* Add support for fetching parent team (for nested teams). (google#723) Create mediaTypeNestedTeamsPreview const for https://developer.github.com/changes/2017-08-30-preview-nested-teams/. Add parent field to the Team struct. Set preview API media type in endpoints that return a team, so that the new parent field gets populated. Helps google#714. * Add NewTeam struct. (google#724) This replaces Team with NewTeam in function that accept a team for creating or editing a team. The NewTeam struct is similar to the existing NewPullRequest for creating pull requests. We need a new struct because the set of parameters for creating or editing a team contains some parameters that are not in the parameter for teams, and most properties of teams cannot be used for editing. The specific change is that Teams are returned with a parent field, but are created/edited with a parent_id field. Helps google#714. * Add NestedTeamsPreview header to remaining endpoints Fixes google#714. * Change ParentTeamID field to int (from string). (google#748) Using the code as written in the `NestedTeamsPreview` branch produces an error when talking to the GitHub API: panic: PATCH https://github.com/api/teams/2514825: 422 Invalid request. For 'properties/parent_team_id', "2514824" is not a number or null. [] The documentation at https://developer.github.com/v3/orgs/teams/#create-team states that this parameter is an id type which appears to mean an integer, not a string. Also, id is an integer in the sample responses for Get team endpoint, etc. * Bump libraryVersion * NestedTeamsPreview: Add the ListChildTeams endpoint (google#758)
GitHub Announcement:
https://developer.github.com/changes/2017-08-30-preview-nested-teams/
This involves adding new endpoints and changing existing endpoints according to the blog post.
Successful completion and closing of this issue involves addressing all the changes described in the GitHub announcement. Note that it doesn't have to all be done in a single PR. It is always a good idea to carefully document what portions are being addressed in any given PR and if there is still work yet to be done.
Thank you in advance for contributing to this open source project!
Your assistance is greatly appreciated.
The text was updated successfully, but these errors were encountered: