-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Support preview Lock Reason via the Lock Issue API #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @gmlewis, I'm willing to work on this. Can you invite me? TIA :) |
Thank you, @anirudhmurali! Invite sent. |
Hey @anirudhmurali, are you working on this? |
No, you can go ahead. |
1. Added preview media type 2. Added ActiveLockReason fields to Issue and PullRequest responses 3. Added LockReason(optional) to the IssuesService.Lock request 4. Added LockReason field to IssueEvent 5. Added and updated test cases.
@gmlewis |
Thank you, @sandlis! Now that we tag this repo with semantic versioning, we no longer have a |
GitHub Developer API announcement:
https://developer.github.com/changes/2018-01-10-lock-reason-api-preview/
Supporting this change will require the following:
application/vnd.github.sailor-v-preview+json
) togithub.go
,active_lock_reason
andlock_reason
fields (ActiveLockReason
andLockReason
in Go, respectively) toIssue
andPullRequest
responses,lock_reason
field (LockReason
in Go) to theIssuesService.Lock
request (which will involve a breaking API change, so that thelibraryVersion
will need to be bumped),lock_reason
(LockReason
in Go) field toIssueEvent
andPullRequestEvent
,libraryVersion
.This is slightly more involved than some of the other recent enhancements, but would still be a good challenge for any new contributor to this repo or to a new Go developer.
All contributions are greatly appreciated. Check out our CONTRIBUTING.md document for more information on how to get started.
Feel free to volunteer for any issue, and we can send you an invite to contribute to the repo (which you then accept) and the issue can be assigned to you so that others don't attempt to duplicate the work.
Thank you!
The text was updated successfully, but these errors were encountered: