Skip to content

Support preview Lock Reason via the Lock Issue API #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks
gmlewis opened this issue Jan 11, 2018 · 6 comments
Closed
6 tasks

Support preview Lock Reason via the Lock Issue API #828

gmlewis opened this issue Jan 11, 2018 · 6 comments

Comments

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 11, 2018

GitHub Developer API announcement:
https://developer.github.com/changes/2018-01-10-lock-reason-api-preview/

Supporting this change will require the following:

  • add a new preview media type (application/vnd.github.sailor-v-preview+json) to github.go,
  • add new active_lock_reason and lock_reason fields (ActiveLockReason and LockReason in Go, respectively) to Issue and PullRequest responses,
  • add a new (optional) lock_reason field (LockReason in Go) to the IssuesService.Lock request (which will involve a breaking API change, so that the libraryVersion will need to be bumped),
  • add a new lock_reason (LockReason in Go) field to IssueEvent and PullRequestEvent,
  • write supporting tests, and
  • bump the libraryVersion.

This is slightly more involved than some of the other recent enhancements, but would still be a good challenge for any new contributor to this repo or to a new Go developer.

All contributions are greatly appreciated. Check out our CONTRIBUTING.md document for more information on how to get started.

Feel free to volunteer for any issue, and we can send you an invite to contribute to the repo (which you then accept) and the issue can be assigned to you so that others don't attempt to duplicate the work.

Thank you!

@anirudhmurali
Copy link

Hey @gmlewis, I'm willing to work on this. Can you invite me? TIA :)

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 12, 2018

Thank you, @anirudhmurali! Invite sent.

@sandeepsukhani
Copy link
Contributor

Hey @anirudhmurali, are you working on this?
If not, would you mind if I pick this up?

@anirudhmurali
Copy link

No, you can go ahead.

sandeepsukhani added a commit to sandeepsukhani/go-github that referenced this issue May 8, 2018
1. Added preview media type
2. Added ActiveLockReason fields to Issue and PullRequest responses
3. Added LockReason(optional) to the IssuesService.Lock request
4. Added LockReason field to IssueEvent
5. Added and updated test cases.
@sandeepsukhani
Copy link
Contributor

@gmlewis
I have created a pull request for this.
Please review and let me know whether it looks good.
I can't find the code for bumping up the version. Can you please point me to that?

@gmlewis
Copy link
Collaborator Author

gmlewis commented May 8, 2018

Thank you, @sandlis! Now that we tag this repo with semantic versioning, we no longer have a libraryVersion so there is no further action needed on your part.

gmlewis pushed a commit to gmlewis/go-github that referenced this issue Aug 10, 2018
n1lesh pushed a commit to n1lesh/go-github that referenced this issue Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants