Skip to content

Remove custom media type for global node IDs #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gmlewis opened this issue Jun 1, 2018 · 1 comment
Closed

Remove custom media type for global node IDs #919

gmlewis opened this issue Jun 1, 2018 · 1 comment
Labels
good first issue

Comments

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 1, 2018

GitHub Developer API announcement:
https://developer.github.com/changes/2018-05-30-end-jean-grey-preview/

The custom media type application/vnd.github.jean-grey-preview+json can be removed from github.go as it is no longer needed. Also please verify that application/vnd.github.v3+json is being sent in the header.
@S2606
Copy link
Contributor

S2606 commented Jun 6, 2018

@gmlewis I would like to work on this

@S2606 S2606 mentioned this issue Jun 6, 2018
Merged
gmlewis pushed a commit that referenced this issue Aug 10, 2018
@S2606 @gmlewis
Remove custom media type for global node IDs (#925)
29a3681 
Fixes #919.
gmlewis pushed a commit to gmlewis/go-github that referenced this issue Aug 10, 2018
@S2606 @gmlewis
Remove custom media type for global node IDs (google#925)
89b460f 
Fixes google#919.
n1lesh pushed a commit to n1lesh/go-github that referenced this issue Oct 2, 2020
@S2606 @gmlewis
Remove custom media type for global node IDs (google#925)
89561b5 
Fixes google#919.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmlewis @S2606