Clean up connection reuse code inside Do func as now Go HTTP packge does it internally #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1645 +/- ##
==========================================
- Coverage 70.02% 70.00% -0.02%
==========================================
Files 97 97
Lines 6328 6324 -4
==========================================
- Hits 4431 4427 -4
Misses 981 981
Partials 916 916
Continue to review full report at Codecov.
|
itsksaurabh
force-pushed
the
master
branch
2 times, most recently
from
45a636b to
0dfb340
Compare
…oes it internally - @itsksaurabh
gmlewis
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
Thank you, @itsksaurabh !
LGTM.
Awaiting second LGTM before merging.
|
Thank you @gmlewis :) |
|
Thank you, @nightlark ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in the PR #1576 are not needed now as the latest official Go Http package does it internally. So Now, it is possible to remove the code from the PR.
https://github.com/golang/go/blob/master/src/net/http/client.go#L698
closes #1646