Skip to content

Add RemoveRequiredStatusChecks API and tests #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2021
Merged

Add RemoveRequiredStatusChecks API and tests #1776

merged 1 commit into from
Jan 18, 2021

Conversation

n1lesh
Copy link
Contributor

@n1lesh n1lesh commented Jan 15, 2021

Fixes #1770

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021 •
edited
Loading

Codecov Report

Merging #1776 (954cd62) into master (9318e62) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1776   +/-   ##
=======================================
  Coverage   97.53%   97.54%           
=======================================
  Files          98       98           
  Lines        6382     6387    +5     
=======================================
+ Hits         6225     6230    +5     
  Misses         85       85           
  Partials       72       72
Impacted Files Coverage Δ
github/repos.go 98.73% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9318e62...954cd62. Read the comment docs.

gmlewis
gmlewis approved these changes Jan 15, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, @n1lesh ... thank you!
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp January 15, 2021 14:22
wesleimp
wesleimp approved these changes Jan 18, 2021
View reviewed changes
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 18, 2021

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit 9c17d51 into google:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@wesleimp wesleimp wesleimp approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a function to remove status check contexts
3 participants
@n1lesh @gmlewis @wesleimp