Skip to content

Clean up unnecessary preview headers #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

n1lesh
Copy link
Contributor

@n1lesh n1lesh commented Jan 23, 2021

Removes unnecessary mediaTypeRequiredApprovingReviewsPreview headers as described in #1779

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jan 23, 2021
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #1782 (9f82ded) into master (9c17d51) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1782      +/-   ##
==========================================
- Coverage   97.54%   97.53%   -0.01%     
==========================================
  Files          98       98              
  Lines        6387     6378       -9     
==========================================
- Hits         6230     6221       -9     
  Misses         85       85              
  Partials       72       72              
Impacted Files Coverage Δ
github/repos.go 98.70% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c17d51...9f82ded. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @n1lesh !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp January 23, 2021 15:13
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 25, 2021

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit 1094add into google:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants