Skip to content

Conversation

alexandear
Copy link
Contributor

This PR combines function parameters by type (with the help of gocritic.paramTypeCombine). See #3654 (comment)

@alexandear alexandear force-pushed the refactor/param-type-combine branch from 3e2e68c to c77318b Compare July 28, 2025 15:15
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.
Merging.

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.25%. Comparing base (ac631dc) to head (c77318b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...xample/codespaces/newreposecretwithxcrypto/main.go 0.00% 2 Missing ⚠️
example/newreposecretwithxcrypto/main.go 0.00% 2 Missing ⚠️
...xample/codespaces/newusersecretwithxcrypto/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3655   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         184      184           
  Lines       16311    16311           
=======================================
  Hits        14884    14884           
  Misses       1245     1245           
  Partials      182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis merged commit a81b973 into google:master Jul 28, 2025
7 checks passed
@alexandear alexandear deleted the refactor/param-type-combine branch July 28, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants