Skip to content

Conversation

alexandear
Copy link
Contributor

This PR enables https://go-critic.com/overview.html#deprecatedcomment to automatically detect cases like #3682 (comment)

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.07%. Comparing base (69dc04b) to head (c2ee58f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3688   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files         186      186           
  Lines       16563    16563           
=======================================
  Hits        15085    15085           
  Misses       1293     1293           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title chore: enable gocritic.deprecatedComment check chore: Enable gocritic.deprecatedComment check Aug 18, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.
Merging.

@gmlewis gmlewis merged commit f137c94 into google:master Aug 18, 2025
7 checks passed
@alexandear alexandear deleted the chore/gocritic-deprecated-comment branch August 18, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants